[payment] Code generation: update services and models#1797
[payment] Code generation: update services and models#1797AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
80bbbb9 to
a0ed471
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new fields to existing payment response models, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request contains auto-generated changes from an OpenAPI definition, adding the cardAltID field to ResponseAdditionalDataCard and networkProcessingMode to ResponseAdditionalDataCommon. The changes are mostly boilerplate for the new fields.
I've added one suggestion to improve the implementation of the new networkProcessingMode field. Using an enum instead of a String would improve type safety and maintainability, which is a pattern already used for similar fields in the same class.
| private boolean isSetMerchantReference = false; | ||
|
|
||
| public static final String JSON_PROPERTY_NETWORK_PROCESSING_MODE = "networkProcessingMode"; | ||
| private String networkProcessingMode; |
There was a problem hiding this comment.
The networkProcessingMode field has a small, fixed set of possible string values ('sale', 'auth'). To improve type safety and prevent errors from typos, it's best to represent this as an enum. This is consistent with other fields in this class like FraudResultTypeEnum.
Here's how you could implement it:
-
Define the enum (as an inner class, similar to others in this file):
/** * Indicates the processing flow. */ public enum NetworkProcessingModeEnum { SALE(String.valueOf("sale")), AUTH(String.valueOf("auth")); private static final Logger LOG = Logger.getLogger(NetworkProcessingModeEnum.class.getName()); private String value; NetworkProcessingModeEnum(String value) { this.value = value; } @JsonValue public String getValue() { return value; } @Override public String toString() { return String.valueOf(value); } @JsonCreator public static NetworkProcessingModeEnum fromValue(String value) { for (NetworkProcessingModeEnum b : NetworkProcessingModeEnum.values()) { if (b.value.equals(value)) { return b; } } LOG.warning( "NetworkProcessingModeEnum: unexpected enum value '" + value + "' - Supported values are " + Arrays.toString(NetworkProcessingModeEnum.values())); return null; } }
-
Update the field type in
ResponseAdditionalDataCommon:private NetworkProcessingModeEnum networkProcessingMode;
-
Update the getter, setter, and fluent setter to use the new enum type:
public ResponseAdditionalDataCommon networkProcessingMode(NetworkProcessingModeEnum networkProcessingMode) { ... } public NetworkProcessingModeEnum getNetworkProcessingMode() { ... } public void setNetworkProcessingMode(NetworkProcessingModeEnum networkProcessingMode) { ... }
| private String networkProcessingMode; | |
| private NetworkProcessingModeEnum networkProcessingMode; |
This PR contains the automated changes for the
paymentservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.