Skip to content

[payment] Code generation: update services and models#1797

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/payment
Open

[payment] Code generation: update services and models#1797
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/payment

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the payment service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners March 16, 2026 16:25
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new fields to existing payment response models, ResponseAdditionalDataCard and ResponseAdditionalDataCommon. These additions enhance the data provided in payment responses, supporting specific regional requirements like alternate card IDs for Indian e-commerce and clarifying transaction processing flows. The changes are a result of automated code generation, ensuring the API models remain synchronized with the latest OpenAPI specifications.

Highlights

  • New Field: cardAltID: The ResponseAdditionalDataCard model has been updated to include a new field, cardAltID, which represents an alternate ID mapped to the Card PAN, specifically for Ecommerce Card Payments in India.
  • New Field: networkProcessingMode: The ResponseAdditionalDataCommon model now includes a networkProcessingMode field, indicating the processing flow (e.g., 'sale' or 'auth') for a transaction.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/java/com/adyen/model/payment/ResponseAdditionalDataCard.java
    • Added JSON_PROPERTY_CARD_ALT_I_D constant.
    • Introduced cardAltID field and its corresponding isSetCardAltID flag.
    • Implemented getter, setter, and fluent setter methods for cardAltID.
    • Updated equals, hashCode, toString, and getExplicitNulls methods to incorporate the new cardAltID field.
  • src/main/java/com/adyen/model/payment/ResponseAdditionalDataCommon.java
    • Added JSON_PROPERTY_NETWORK_PROCESSING_MODE constant.
    • Introduced networkProcessingMode field and its corresponding isSetNetworkProcessingMode flag.
    • Implemented getter, setter, and fluent setter methods for networkProcessingMode.
    • Updated equals, hashCode, toString, and getExplicitNulls methods to incorporate the new networkProcessingMode field.
Activity
  • This pull request was automatically generated by AdyenAutomationBot.
  • The changes reflect updates from adyen-openapi commits, indicating an automated synchronization process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request contains auto-generated changes from an OpenAPI definition, adding the cardAltID field to ResponseAdditionalDataCard and networkProcessingMode to ResponseAdditionalDataCommon. The changes are mostly boilerplate for the new fields.

I've added one suggestion to improve the implementation of the new networkProcessingMode field. Using an enum instead of a String would improve type safety and maintainability, which is a pattern already used for similar fields in the same class.

private boolean isSetMerchantReference = false;

public static final String JSON_PROPERTY_NETWORK_PROCESSING_MODE = "networkProcessingMode";
private String networkProcessingMode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The networkProcessingMode field has a small, fixed set of possible string values ('sale', 'auth'). To improve type safety and prevent errors from typos, it's best to represent this as an enum. This is consistent with other fields in this class like FraudResultTypeEnum.

Here's how you could implement it:

  1. Define the enum (as an inner class, similar to others in this file):

    /**
     * Indicates the processing flow.
     */
    public enum NetworkProcessingModeEnum {
      SALE(String.valueOf("sale")),
    
      AUTH(String.valueOf("auth"));
    
      private static final Logger LOG = Logger.getLogger(NetworkProcessingModeEnum.class.getName());
    
      private String value;
    
      NetworkProcessingModeEnum(String value) {
        this.value = value;
      }
    
      @JsonValue
      public String getValue() {
        return value;
      }
    
      @Override
      public String toString() {
        return String.valueOf(value);
      }
    
      @JsonCreator
      public static NetworkProcessingModeEnum fromValue(String value) {
        for (NetworkProcessingModeEnum b : NetworkProcessingModeEnum.values()) {
          if (b.value.equals(value)) {
            return b;
          }
        }
        LOG.warning(
            "NetworkProcessingModeEnum: unexpected enum value '" + value + "' - Supported values are " + Arrays.toString(NetworkProcessingModeEnum.values()));
        return null;
      }
    }
  2. Update the field type in ResponseAdditionalDataCommon:

    private NetworkProcessingModeEnum networkProcessingMode;
  3. Update the getter, setter, and fluent setter to use the new enum type:

    public ResponseAdditionalDataCommon networkProcessingMode(NetworkProcessingModeEnum networkProcessingMode) { ... }
    public NetworkProcessingModeEnum getNetworkProcessingMode() { ... }
    public void setNetworkProcessingMode(NetworkProcessingModeEnum networkProcessingMode) { ... }
Suggested change
private String networkProcessingMode;
private NetworkProcessingModeEnum networkProcessingMode;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant