Remove Three Zone Code and Examples#1056
Draft
dhensle wants to merge 5 commits intoActivitySim:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes all code and configuration related to the "THREE_ZONE" system's TVPB (Transit Virtual Path Builder) logsum caching and processing from the ActivitySim codebase. The changes simplify several model steps, eliminate specialized caching logic, and update workflow and settings references accordingly.
Removal of THREE_ZONE TVPB logsum logic:
activitysim/abm/models/atwork_subtour_mode_choice.py,activitysim/abm/models/tour_mode_choice.py, andactivitysim/abm/models/trip_destination.py, including the creation, updating, and use of TVPB logsum skims and constants. [1] [2] [3] [4] [5] [6] [7] [8] [9]Workflow and settings updates:
initialize_los.pyfile, which contained all logic for initializing TVPB caches and attribute combinations for THREE_ZONE systems.initialize_losstep from the settings checker inactivitysim/abm/models/settings_checker.py, preventing references to its settings file.Configuration cleanup:
.github/workflows/core_tests.ymlfile, eliminating test runs for obsolete configurations.General codebase simplification:
Example models removed: