-
Notifications
You must be signed in to change notification settings - Fork 725
fix(plugin): sanitize markdown and prevent horizontal overflow #1782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin): sanitize markdown and prevent horizontal overflow #1782
Conversation
bajrangCoder
commented
Dec 30, 2025
- Remove <style> tags from plugin markdown via DOMPurify FORBID_TAGS
- Prevent horizontal overflow in markdown content sections
- Improve table styling with proper borders, padding, and hover effects
- Improve hr styling to use theme-consistent border color
- Add word-break and overflow-wrap for long content
- Make tables and images responsive with max-width constraints
- Remove <style> tags from plugin markdown via DOMPurify FORBID_TAGS - Prevent horizontal overflow in markdown content sections - Improve table styling with proper borders, padding, and hover effects - Improve hr styling to use theme-consistent border color - Add word-break and overflow-wrap for long content - Make tables and images responsive with max-width constraints
Summary of ChangesHello @bajrangCoder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the display and security of markdown content within the plugin. It introduces robust sanitization to prevent malicious style injections, improves content readability by preventing horizontal overflow and ensuring responsiveness for images and tables, and refines the visual presentation of tables and horizontal rules for a more consistent and user-friendly experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several good improvements for rendering markdown content. It enhances security by sanitizing <style> tags, and improves the layout by preventing horizontal overflow and making elements like images and tables responsive. The styling for tables and horizontal rules is also much improved and consistent with the theme.
My review includes a few suggestions for the SCSS changes to improve maintainability by removing redundant properties and avoiding overly broad CSS selectors. Overall, this is a solid set of changes.