-
Notifications
You must be signed in to change notification settings - Fork 724
feat: add quiet hours for ads #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @RohitKushvaha01, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a user-centric feature that automatically mutes advertisements during specified 'quiet hours' to prevent disturbances. By configuring the AdMob SDK to respect these times, the application aims to provide a less intrusive experience for users, particularly during late-night or early-morning usage. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a 'quiet hours' feature to mute ads between 10 PM and 5 AM. The implementation is straightforward and correct. My main feedback is to replace the hardcoded start and end hours with named constants to improve code readability and maintainability. This also makes it easier to adjust these times in the future or expose them as user settings.
bajrangCoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me 👍
Btw instead of 5 keep it to 4 AM
This PR mutes ads if the app is launched between 10 PM and 5 AM. During this time, any video ads will have their volume set to zero, though this is not guaranteed. This may also affect the eCPM of ads during this time range, as already discussed.
Closes #1293