build: SG-42130: XCode26 support#1091
Merged
cedrik-fuoco-adsk merged 9 commits intoAcademySoftwareFoundation:mainfrom Mar 2, 2026
Merged
build: SG-42130: XCode26 support#1091cedrik-fuoco-adsk merged 9 commits intoAcademySoftwareFoundation:mainfrom
cedrik-fuoco-adsk merged 9 commits intoAcademySoftwareFoundation:mainfrom
Conversation
mcoliver
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
cedrik-fuoco-adsk
approved these changes
Feb 12, 2026
Contributor
cedrik-fuoco-adsk
left a comment
cedrik-fuoco-adsk
left a comment
There was a problem hiding this comment.
Thank you for fixing that! Did you encounter any other build issue or warning that came with using XCode 26?
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an automated workaround to build with Xcode 26+ on macOS by patching community Qt installs to avoid AGL, and updates docs/config accordingly.
Changes:
- Auto-detect Xcode 26+ in
rvcmds.shand run a Qt patching script. - Add
apply_qt_fix.shandqt_fix.patchto remove AGL references from Qt files. - Update macOS build documentation and tweak Python CMake target properties.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| rvcmds.sh | Detects Xcode 26+ on macOS and invokes Qt patch application automatically. |
| apply_qt_fix.sh | New script to apply an AGL-removal patch to specific Qt versions. |
| qt_fix.patch | Patch content that removes AGL framework/header usage from Qt config files. |
| docs/build_system/config_macos.md | Documents the new Xcode 26+ Qt patch requirement and how it’s applied. |
| cmake/dependencies/python3.cmake | Alters properties of the imported Python::Python target (potentially to affect system include handling). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bernie-laberge
approved these changes
Feb 17, 2026
Contributor
There was a problem hiding this comment.
LGTM
Thank you @mcoliver for this great contribution !
cedrik-fuoco-adsk
changed the title
Contributor
|
I updated your branch to main to test it locally on my MacBook, but there are some issues with pre-commit again. |
cedrik-fuoco-adsk
changed the title
Contributor
|
Hi @mcoliver, we would be ready to merge the PR. Do you have time to fix the various issues? |
Contributor
Author
Hi @cedrik-fuoco-adsk Accepted some of the suggestions and ran |
Signed-off-by: Michael Oliver <mcoliver@gmail.com>
XCode26 was refusing to build Qt 6.5.3 and 6.8.3 because it lacks AGL. AGL is no longer used and newer versions of Qt have patched. This is a backport to patch 6.5.3 and 6.8.3. For reference: https://qt-project.atlassian.net/browse/QTBUG-137687 qt/qtbase@cdb33c3 Homebrew/homebrew-core@9ef0937 Signed-off-by: Michael Oliver <mcoliver@gmail.com>
updated cmake/dependencies/python3.cmake to use the IMPORTED_NO_SYSTEM property for the Python::Python target. This ensures that the Python include paths are treated as regular include paths (-I) rather than system include paths (-isystem), which resolves search order issues on newer Xcode versions. Signed-off-by: Michael Oliver <mcoliver@gmail.com>
Signed-off-by: Michael Oliver <mcoliver@gmail.com>
cmake-format -i CMakeLists.txt cmake/**/*.cmake Signed-off-by: Michael Oliver <mcoliver@gmail.com>
See this link for more details https://cmake.org/cmake/help/v3.31/prop_tgt/IMPORTED_NO_SYSTEM.html Signed-off-by: Michael Oliver <mcoliver@gmail.com>
non code changes. Grammatical fixes to docs. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Michael Oliver <mcoliver@gmail.com>
Signed-off-by: Michael Oliver <mcoliver@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Michael Oliver <mcoliver@gmail.com>
Contributor
|
Thank you @mcoliver ! I'll merge it |
cedrik-fuoco-adsk
merged commit 946e73c
into
AcademySoftwareFoundation:main
20 checks passed
chenlj1
pushed a commit
to chenlj1/OpenRV
that referenced
this pull request
Mar 6, 2026
### [ 1090: Build with Xcode26 ] ### Linked issues Fixes AcademySoftwareFoundation#1090 ### Summarize your change. Backported a patch to Qt 6.5.3 and 6.8.3 which are the community versions available and do not have the patch in commercial versions ### Describe the reason for the change. Want to build with Xcode26. Was annoying to constantly have to switch with xcode-select. Additionally xcode26 should bring some compiler optimizations that may improve performance. ### Describe what you have tested and on which operating system. macos26.2 with Xcode26.2. RV CY2025 --------- Signed-off-by: Michael Oliver <mcoliver@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ 1090: Build with Xcode26 ]
Linked issues
Fixes #1090
Summarize your change.
Backported a patch to Qt 6.5.3 and 6.8.3 which are the community versions available and do not have the patch in commercial versions
Describe the reason for the change.
Want to build with Xcode26. Was annoying to constantly have to switch with xcode-select. Additionally xcode26 should bring some compiler optimizations that may improve performance.
Describe what you have tested and on which operating system.
macos26.2 with Xcode26.2. RV CY2025