allow screening routine to output log(screening)#1939
Merged
zingale merged 7 commits intoAMReX-Astro:developmentfrom Feb 16, 2026
Merged
allow screening routine to output log(screening)#1939zingale merged 7 commits intoAMReX-Astro:developmentfrom
zingale merged 7 commits intoAMReX-Astro:developmentfrom
Conversation
zingale
reviewed
Feb 10, 2026
screening/_parameters
Outdated
| enable_chabrier1998_quantum_corr bool 0 | ||
| enable_debye_huckel_skip bool 0 | ||
| debye_huckel_skip_threshold real 1.01e0 | ||
| debye_huckel_skip_threshold real 1.0e-3 |
Member
There was a problem hiding this comment.
shouldn't this be std::log(1.01) ~ 1.e-2?
Collaborator
Author
There was a problem hiding this comment.
yes, you're right -- I was bad at counting zeros. Fixed
zingale
approved these changes
Feb 16, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let screening routines to return
hinstead ofexp(h). This is mainly group log(screen) term with log(rates) so that we reduce the number of exp calls. It is needed for pynucastro/pynucastro#1259