Skip to content

feat: Add pullImage option to ComposeCreate to swith pull operation #11667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssongliu merged 2 commits into from
Jan 16, 2026
Merged

feat: Add pullImage option to ComposeCreate to swith pull operation #11667

ssongliu merged 2 commits into from
Jan 16, 2026
+26 −9

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Jan 16, 2026 •
edited
Loading

What this PR does / why we need it?

#11658

Summary of your change

开关关闭时 uptask 会直接绕过 pull 过程 直接docker compose up
image
image

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@HynoR
feat: Add pullImage option to ComposeCreate and update related logic
5794664 
- Introduced a new optional field `pullImage` in the `ComposeCreate` struct to control image pulling behavior.
- Updated `CreateCompose` method to handle the `pullImage` flag when invoking the compose up command.
- Modified `UpWithTask` function to conditionally skip image pulling based on the `pullImages` parameter.
- Enhanced frontend form to include a checkbox for the `pullImage` option, with default value set to true.
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 16, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HynoR HynoR marked this pull request as ready for review January 16, 2026 07:54
@HynoR HynoR changed the title feat: Add pullImage option to ComposeCreate and update related logic feat: Add pullImage option to ComposeCreate to swith pull operation Jan 16, 2026
@ssongliu ssongliu merged commit 365936b into 1Panel-dev:dev-v2 Jan 16, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wanghe-fit2cloud wanghe-fit2cloud Awaiting requested review from wanghe-fit2cloud

@zhengkunwang223 zhengkunwang223 Awaiting requested review from zhengkunwang223

Assignees

No one assigned

Labels

do-not-merge/release-note-label-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HynoR @ssongliu