Refactor getByDateTime & getParts with explicit arguments#5
Merged
Refactor getByDateTime & getParts with explicit arguments#5
getByDateTime & getParts with explicit arguments#5Conversation
less branches to account for handle Date & DateTime Regex with nullish coalescing early return on errors
mxdvl
commented
Jul 25, 2025
zachleat
approved these changes
Jul 25, 2025
to reduce repetition!
zachleat
approved these changes
Jul 28, 2025
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why propose this change?
More explicit arguments for
getByDateTimeand explicit default values.Less branches as
getPartsalways callsgetByDateTime, so we rely on nullish coalesing for handling the Date & DateTime Regexes. Returning early for errors reduces nesting & indentation.This is in a similar vein to #4 but the changes are independent.