Skip to content

Simplify retrieval of collections.all in getLocaleCollectionItem #3785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noelforte wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −5
Open

Simplify retrieval of collections.all in getLocaleCollectionItem #3785

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c16992
simplify access to collections.all (and prevent breakage in custom en…
noelforte Apr 28, 2025
f40930f
Merge branch 'main' into i18n-page-resolution
noelforte Aug 2, 2025
006a908
Merge branch 'main' into i18n-page-resolution
noelforte Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/Filters/GetLocaleCollectionItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,8 @@ function getLocaleCollectionItem(config, collection, pageOverride, langCode, ind
}

// find the modified locale `page` again in `collections.all`
let all =
this.collections?.all ||
this.ctx?.collections?.all ||
this.context?.environments?.collections?.all ||
[];
let all = this.collections?.all || this.data?.collections?.all || [];

return getCollectionItem(all, modifiedLocalePage, 0);
}

Expand Down