Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes an async deadlock issue that occurs when there are circular dependencies during dependency injection. The fix introduces early detection of recursive instantiation calls and improves thread-safety configuration.
- Adds circular dependency detection in
CacheLogicby tracking instantiation state and raisingRecursionErrorwhen recursion is detected - Improves environment variable parsing for thread-safety configuration to properly handle numeric values
- Adds
threadsafeparameter to injection provider methods for better control over locking behavior
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updates dependency versions: backports-zstd (1.2.0 → 1.3.0), pymdown-extensions (10.19.1 → 10.20), and uv (0.9.18 → 0.9.21) |
| injection/_core/scope.py | Removes redundant ScopeKind conversion since the type annotation already enforces valid values through ScopeKind | ScopeKindStr |
| injection/_core/locator.py | Adds threadsafe parameter to make_injected_function, passes threadsafe=False for recipe injection to prevent deadlocks, and renames value to injectable for clarity |
| injection/_core/injectables.py | Implements circular dependency detection by tracking instantiation state with __is_instantiating flag and raising RecursionError when recursive calls are detected |
| injection/_core/common/threading.py | Fixes environment variable parsing to properly handle PYTHON_INJECTION_THREADSAFE as an integer value, and improves variable naming from cond to threadsafe |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.