Skip to content

Commit 516f16f

Browse files
pranaygpclaude
andcommitted
fix(ci): ensure publish-results job runs when E2E tests fail
The publish-results job was being skipped because it depends on the summary job which uses `if: always()`. When a job uses `always()`, downstream jobs need to also use `always()` in their condition, otherwise GitHub Actions skips them when any upstream job fails. This was causing e2e-results.json to never be published to gh-pages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent b28cd84 commit 516f16f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -658,7 +658,8 @@ jobs:
658658
name: Publish E2E Results
659659
runs-on: ubuntu-latest
660660
needs: [summary]
661-
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
661+
# Use always() because summary uses always() - without it this job gets skipped when any E2E test fails
662+
if: always() && !cancelled() && github.event_name == 'push' && github.ref == 'refs/heads/main'
662663
timeout-minutes: 5
663664

664665
permissions:

0 commit comments

Comments
 (0)