Skip to content

Commit 5219ae8

Browse files
committed
Merge remote-tracking branch 'origin/release/v10.9.5' into release/v10.9.5
2 parents 428e9bd + bb4fe32 commit 5219ae8

File tree

4 files changed

+28
-50
lines changed

4 files changed

+28
-50
lines changed
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
package com.park.utmstack.service.dto.collectors.dto;
2+
3+
import com.park.utmstack.domain.application_modules.UtmModuleGroupConfiguration;
4+
import lombok.Getter;
5+
import lombok.Setter;
6+
7+
import javax.validation.constraints.NotNull;
8+
import java.util.List;
9+
10+
@Setter
11+
@Getter
12+
public class CollectorConfigDTO {
13+
@NotNull
14+
CollectorDTO collector;
15+
@NotNull
16+
private Long moduleId;
17+
@NotNull
18+
private List<UtmModuleGroupConfiguration> keys;
19+
20+
}

backend/src/main/java/com/park/utmstack/service/dto/collectors/dto/CollectorConfigKeysDTO.java

Lines changed: 0 additions & 39 deletions
This file was deleted.

backend/src/main/java/com/park/utmstack/service/validators/collector/CollectorValidatorService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.park.utmstack.service.validators.collector;
22

33
import com.park.utmstack.domain.application_modules.UtmModuleGroupConfiguration;
4-
import com.park.utmstack.service.dto.collectors.dto.CollectorConfigKeysDTO;
4+
import com.park.utmstack.service.dto.collectors.dto.CollectorConfigDTO;
55
import org.springframework.stereotype.Service;
66
import org.springframework.validation.Errors;
77
import org.springframework.validation.Validator;
@@ -13,12 +13,12 @@
1313
public class CollectorValidatorService implements Validator {
1414
@Override
1515
public boolean supports(Class<?> clazz) {
16-
return CollectorConfigKeysDTO.class.equals(clazz);
16+
return CollectorConfigDTO.class.equals(clazz);
1717
}
1818

1919
@Override
2020
public void validate(Object target, Errors errors) {
21-
CollectorConfigKeysDTO updateConfigurationKeysBody = (CollectorConfigKeysDTO) target;
21+
CollectorConfigDTO updateConfigurationKeysBody = (CollectorConfigDTO) target;
2222

2323
Map<String, Long> hostNames = updateConfigurationKeysBody.getKeys().stream()
2424
.filter(config -> config.getConfName().equals("Hostname"))

backend/src/main/java/com/park/utmstack/web/rest/collectors/UtmCollectorResource.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,13 @@
1616
import com.park.utmstack.service.application_modules.UtmModuleGroupService;
1717
import com.park.utmstack.service.collectors.CollectorOpsService;
1818
import com.park.utmstack.service.collectors.UtmCollectorService;
19-
import com.park.utmstack.service.dto.collectors.dto.CollectorConfigKeysDTO;
19+
import com.park.utmstack.service.dto.collectors.dto.CollectorConfigDTO;
2020
import com.park.utmstack.service.dto.collectors.dto.CollectorDTO;
2121
import com.park.utmstack.service.dto.collectors.CollectorModuleEnum;
2222
import com.park.utmstack.service.dto.collectors.dto.ListCollectorsResponseDTO;
2323
import com.park.utmstack.service.dto.network_scan.AssetGroupDTO;
2424
import com.park.utmstack.service.validators.collector.CollectorValidatorService;
2525
import com.park.utmstack.util.UtilResponse;
26-
import com.park.utmstack.web.rest.application_modules.UtmModuleGroupConfigurationResource;
2726
import com.park.utmstack.web.rest.errors.BadRequestAlertException;
2827
import com.park.utmstack.web.rest.errors.InternalServerErrorException;
2928
import com.park.utmstack.web.rest.network_scan.UtmNetworkScanResource;
@@ -94,9 +93,7 @@ public UtmCollectorResource(CollectorOpsService collectorService,
9493
* persist the configurations.
9594
*/
9695
@PostMapping("/collector-config")
97-
public ResponseEntity<Void> upsertCollectorConfig(
98-
@Valid @RequestBody CollectorConfigKeysDTO collectorConfig,
99-
CollectorDTO collectorDTO) {
96+
public ResponseEntity<Void> upsertCollectorConfig(@Valid @RequestBody CollectorConfigDTO collectorConfig) {
10097
final String ctx = CLASSNAME + ".upsertCollectorConfig";
10198

10299
try {
@@ -112,11 +109,11 @@ public ResponseEntity<Void> upsertCollectorConfig(
112109

113110
// Get the actual configuration just in case of error when updating local db.
114111
CollectorConfig cacheConfig = collectorService.getCollectorConfig(
115-
ConfigRequest.newBuilder().setModule(CollectorModule.valueOf(collectorDTO.getModule().toString())).build(),
116-
AuthResponse.newBuilder().setId(collectorDTO.getId()).setKey(collectorDTO.getCollectorKey()).build());
112+
ConfigRequest.newBuilder().setModule(CollectorModule.valueOf(collectorConfig.getCollector().getModule().toString())).build(),
113+
AuthResponse.newBuilder().setId(collectorConfig.getCollector().getId()).setKey(collectorConfig.getCollector().getCollectorKey()).build());
117114
// Map the configurations to gRPC CollectorConfig and try to insert/update the collector config
118115
collectorService.upsertCollectorConfig(collectorService.mapToCollectorConfig(
119-
collectorService.mapPasswordConfiguration(collectorConfig.getKeys()), collectorDTO));
116+
collectorService.mapPasswordConfiguration(collectorConfig.getKeys()), collectorConfig.getCollector()));
120117
// If the update is fine via gRPC, then update the configurations in local db.
121118
try {
122119
moduleGroupConfigurationService.updateConfigurationKeys(collectorConfig.getModuleId(), collectorConfig.getKeys());

0 commit comments

Comments
 (0)