Update code to make BasicAuth more usable and let LDAPAuth extend basicauth

Author: jgerits

trino-csharp/Trino.Client/Auth/BasicAuth.cs

@@ -5,7 +5,7 @@
 namespace Trino.Client.Auth
 {
     /// <summary>
-    /// For testing purposes, you can use the BasicAuth class to authenticate with Trino.
+    /// For setting up basic authentication with a username and optional password.
     /// </summary>
     public class BasicAuth : ITrinoAuth
     {
@@ -19,7 +19,12 @@ public string User
             set;
         }
 
-        public void AuthorizeAndValidate()
+        public string Password { 
+            get; 
+            set; 
+        }
+
+        public virtual void AuthorizeAndValidate()
         {
             if (string.IsNullOrEmpty(User) )
             {
@@ -33,7 +38,10 @@ public void AuthorizeAndValidate()
         /// <param name="httpRequestMessage">Http request message</param>
         public virtual void AddCredentialToRequest(HttpRequestMessage httpRequestMessage)
         {
-            var credentials = Convert.ToBase64String(Encoding.ASCII.GetBytes($"{User}" ));
+           var credentials = Convert.ToBase64String(string.IsNullOrEmpty(Password) ? 
+                          Encoding.ASCII.GetBytes($"{User}") : 
+                          Encoding.ASCII.GetBytes($"{User}:{Password}"));
+
             httpRequestMessage.Headers.Add("Authorization", "Basic " + credentials);
         }
     }

trino-csharp/Trino.Client/Auth/LDAPAuth.cs

@@ -4,40 +4,18 @@
 
 namespace Trino.Client.Auth
 {
-    public class LDAPAuth : ITrinoAuth
+    public class LDAPAuth : BasicAuth
     {
         public LDAPAuth()
         {
         }
 
-        public string User
-        {
-            get;
-            set;
-        }
-
-        public string Password
-        {
-            get;
-            set;
-        }
-
-        public void AuthorizeAndValidate()
+        public override void AuthorizeAndValidate()
         {
             if (string.IsNullOrEmpty(User) || string.IsNullOrEmpty(Password))
             {
                 throw new ArgumentException("LDAPAuth: username or password property is null or empty");
             }
         }
-
-        /// <summary>
-        /// Modify the request with authentication
-        /// </summary>
-        /// <param name="httpRequestMessage">Http request message</param>
-        public virtual void AddCredentialToRequest(HttpRequestMessage httpRequestMessage)
-        {
-            var credentials = Convert.ToBase64String(Encoding.ASCII.GetBytes($"{User}:{Password}"));
-            httpRequestMessage.Headers.Add("Authorization", "Basic " + credentials);
-        }
     }
 }