[Site] Address PR review feedback

- Use PascalCase for enum values (Normal instead of NORMAL)
- Use named arguments in Animalz constructor
- Cache this.results in template variable to avoid double call

Author: Nayte91

ux.symfony.com/src/Enum/AnimalzType.php

@@ -15,16 +15,16 @@
 
 enum AnimalzType: string
 {
-    case Normal = 'NORMAL';
-    case Water = 'WATER';
-    case Flying = 'FLYING';
-    case Bug = 'BUG';
-    case Fight = 'FIGHT';
-    case Dark = 'DARK';
-    case Poison = 'POISON';
-    case Grass = 'GRASS';
-    case Fairy = 'FAIRY';
-    case Fossil = 'FOSSIL';
+    case Normal = 'Normal';
+    case Water = 'Water';
+    case Flying = 'Flying';
+    case Bug = 'Bug';
+    case Fight = 'Fight';
+    case Dark = 'Dark';
+    case Poison = 'Poison';
+    case Grass = 'Grass';
+    case Fairy = 'Fairy';
+    case Fossil = 'Fossil';
 
     public function getColor(): string
     {

ux.symfony.com/src/Service/AnimalzRepository.php

@@ -88,11 +88,11 @@ private function loadZanimalz(): array
 
         return array_map(
             fn (array $item): Animalz => new Animalz(
-                $item['name'],
-                AnimalzType::from($item['type'][0]),
-                isset($item['type'][1]) ? AnimalzType::from($item['type'][1]) : null,
-                $item['legs'],
-                $item['description'],
+                name: $item['name'],
+                type1: AnimalzType::from($item['type'][0]),
+                type2: isset($item['type'][1]) ? AnimalzType::from($item['type'][1]) : null,
+                legs: $item['legs'],
+                description: $item['description'],
             ),
             $data,
         );