feat(no-navigation-without-resolve): not reporting pure query URLs

Author: marekdedic

.changeset/eager-snails-follow.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': minor
+---
+
+feat(no-navigation-without-resolve): not reporting pure query URLs

packages/eslint-plugin-svelte/src/rules/no-navigation-without-resolve.ts

@@ -258,8 +258,9 @@ function isValueAllowed(
 	if (
 		(config.allowAbsolute && expressionIsAbsoluteUrl(ctx, value)) ||
 		(config.allowEmpty && expressionIsEmpty(value)) ||
-		(config.allowFragment && expressionIsFragment(ctx, value)) ||
+		(config.allowFragment && expressionStartsWith(ctx, value, '#')) ||
 		(config.allowNullish && expressionIsNullish(value)) ||
+		expressionStartsWith(ctx, value, '?') ||
 		expressionIsResolveCall(ctx, value, resolveReferences)
 	) {
 		return true;
@@ -365,34 +366,40 @@ function valueIsAbsoluteUrl(node: string): boolean {
 	return /^[+a-z]*:/i.test(node);
 }
 
-function expressionIsFragment(
+function expressionStartsWith(
 	ctx: FindVariableContext,
-	node: TSESTree.CallExpressionArgument | TSESTree.Expression | AST.SvelteLiteral
+	node: TSESTree.CallExpressionArgument | TSESTree.Expression | AST.SvelteLiteral,
+	prefix: string
 ): boolean {
 	switch (node.type) {
 		case 'BinaryExpression':
-			return binaryExpressionIsFragment(ctx, node);
+			return binaryExpressionStartsWith(ctx, node, prefix);
 		case 'Identifier':
-			return identifierIsFragment(ctx, node);
+			return identifierStartsWith(ctx, node, prefix);
 		case 'Literal':
-			return typeof node.value === 'string' && urlValueIsFragment(node.value);
+			return typeof node.value === 'string' && node.value.startsWith(prefix);
 		case 'SvelteLiteral':
-			return urlValueIsFragment(node.value);
+			return node.value.startsWith(prefix);
 		case 'TemplateLiteral':
-			return templateLiteralIsFragment(ctx, node);
+			return templateLiteralStartsWith(ctx, node, prefix);
 		default:
 			return false;
 	}
 }
 
-function binaryExpressionIsFragment(
+function binaryExpressionStartsWith(
 	ctx: FindVariableContext,
-	node: TSESTree.BinaryExpression
+	node: TSESTree.BinaryExpression,
+	prefix: string
 ): boolean {
-	return node.left.type !== 'PrivateIdentifier' && expressionIsFragment(ctx, node.left);
+	return node.left.type !== 'PrivateIdentifier' && expressionStartsWith(ctx, node.left, prefix);
 }
 
-function identifierIsFragment(ctx: FindVariableContext, node: TSESTree.Identifier): boolean {
+function identifierStartsWith(
+	ctx: FindVariableContext,
+	node: TSESTree.Identifier,
+	prefix: string
+): boolean {
 	const variable = ctx.findVariable(node);
 	if (
 		variable === null ||
@@ -402,19 +409,16 @@ function identifierIsFragment(ctx: FindVariableContext, node: TSESTree.Identifie
 	) {
 		return false;
 	}
-	return expressionIsFragment(ctx, variable.identifiers[0].parent.init);
+	return expressionStartsWith(ctx, variable.identifiers[0].parent.init, prefix);
 }
 
-function templateLiteralIsFragment(
+function templateLiteralStartsWith(
 	ctx: FindVariableContext,
-	node: TSESTree.TemplateLiteral
+	node: TSESTree.TemplateLiteral,
+	prefix: string
 ): boolean {
 	return (
-		(node.expressions.length >= 1 && expressionIsFragment(ctx, node.expressions[0])) ||
-		(node.quasis.length >= 1 && urlValueIsFragment(node.quasis[0].value.raw))
+		(node.expressions.length >= 1 && expressionStartsWith(ctx, node.expressions[0], prefix)) ||
+		(node.quasis.length >= 1 && node.quasis[0].value.raw.startsWith(prefix))
 	);
 }
-
-function urlValueIsFragment(node: string): boolean {
-	return node.startsWith('#');
-}

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/valid/goto-query01-input.svelte

@@ -0,0 +1,13 @@
+<script>
+	import { goto } from '$app/navigation';
+
+	const keyValue = 'bar=baz';
+	const value = '?foo=bar';
+
+	goto('?');
+	goto('?foo=bar');
+	goto('?' + 'foo=bar');
+	goto('?' + keyValue);
+	goto(`?${keyValue}`);
+	goto(value);
+</script>

…e/valid/link-fragment-url01-input.svelte …solve/valid/link-fragment01-input.sveltepackages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/valid/link-fragment-url01-input.svelte renamed to packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/valid/link-fragment01-input.svelte packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/valid/link-fragment-url01-input.svelte renamed to packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/valid/link-fragment01-input.svelte

@@ -0,0 +1,15 @@
+<script>
+	const keyValue = 'bar=baz';
+
+	const value = '?foo=bar';
+	const href = '?foo=bar';
+</script>
+
+<a href="?">Click me!</a>
+<a href="?foo=bar">Click me!</a>
+<a href={'?foo=bar'}>Click me!</a>
+<a href={'?' + 'foo=bar'}>Click me!</a>
+<a href={'#' + keyValue}>Click me!</a>
+<a href={`#${keyValue}`}>Click me!</a>
+<a href={value}>Click me!</a>
+<a {href}>Click me!</a>

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/valid/link-query01-input.svelte

@@ -0,0 +1,13 @@
+<script>
+	import { pushState } from '$app/navigation';
+
+	const keyValue = 'bar=baz';
+	const value = '?foo=bar';
+
+	pushState('?');
+	pushState('?foo=bar');
+	pushState('?' + 'foo=bar');
+	pushState('?' + keyValue);
+	pushState(`?${keyValue}`);
+	pushState(value);
+</script>

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/valid/pushState-query01-input.svelte

@@ -0,0 +1,13 @@
+<script>
+	import { replaceState } from '$app/navigation';
+
+	const keyValue = 'bar=baz';
+	const value = '?foo=bar';
+
+	replaceState('?');
+	replaceState('?foo=bar');
+	replaceState('?' + 'foo=bar');
+	replaceState('?' + keyValue);
+	replaceState(`?${keyValue}`);
+	replaceState(value);
+</script>