Skip to content

[6.x] Fix checkbox indeterminate state #13446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 3 commits into from
Jan 7, 2026
Merged

[6.x] Fix checkbox indeterminate state #13446

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8bab8f
Displays a checkbox in an indeterminate state (shows a dash) when not…
JayGeorge Jan 7, 2026
fbf4b1e
Make the dash a touch shorter
JayGeorge Jan 7, 2026
808088a
Make entries selection screen reader text localizable
JayGeorge Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions resources/js/components/ui/Checkbox/Item.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ const props = defineProps({
description: { type: String, default: null },
/** When `true`, disables the checkbox */
disabled: { type: Boolean, default: false },
/** When `true`, displays the checkbox in an indeterminate state (shows a dash) */
indeterminate: { type: Boolean, default: false },
/** Label text to display next to the checkbox */
label: { type: String, default: null },
/** The controlled value of the checkbox */
Expand Down Expand Up @@ -45,6 +47,7 @@ const checkboxClasses = computed(() => {
'shadow-ui-xs mt-0.5 cursor-default rounded-sm border border-gray-400/75 bg-white',
'dark:bg-gray-500 dark:border-gray-900',
'data-[state=checked]:border-ui-accent-bg data-[state=checked]:bg-ui-accent-bg',
'data-[state=indeterminate]:border-ui-accent-bg data-[state=indeterminate]:bg-ui-accent-bg',
'dark:border-none',
'dark:data-[disabled]:bg-ui-accent-bg/60 dark:data-[disabled]:border-ui-accent-bg/70',
'dark:data-[disabled]:text-gray-400 dark:data-[disabled]:cursor-not-allowed',
Expand Down Expand Up @@ -78,6 +81,10 @@ const conditionalProps = computed(() => {
props_obj.modelValue = props.modelValue;
}

if (props.indeterminate) {
props_obj.indeterminate = true;
}

// Only add aria-describedby if description exists AND it's not a solo checkbox
if (props.description && !props.solo) {
props_obj['aria-describedby'] = `${id}-description`;
Expand Down Expand Up @@ -105,10 +112,13 @@ const conditionalProps = computed(() => {
:tabindex="tabindex"
>
<CheckboxIndicator class="relative flex h-full w-full items-center justify-center text-white">
<svg viewBox="0 0 10 8" fill="none" xmlns="http://www.w3.org/2000/svg" class="size-2.5 shrink-0" aria-hidden="true"><path d="M9 1L3.5 6.5L1 4" stroke="currentColor" stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round" /></svg>
<!-- Checkmark icon for checked state -->
<svg v-if="!indeterminate" viewBox="0 0 10 8" fill="none" xmlns="http://www.w3.org/2000/svg" class="size-2.5 shrink-0" aria-hidden="true"><path d="M9 1L3.5 6.5L1 4" stroke="currentColor" stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round" /></svg>
<!-- Dash icon for indeterminate state -->
<svg v-else viewBox="0 0 10 2" fill="none" xmlns="http://www.w3.org/2000/svg" class="size-2.5 shrink-0" aria-hidden="true"><path d="M2 1H8" stroke="currentColor" stroke-width="1.5" stroke-linecap="round" /></svg>
</CheckboxIndicator>
<span class="sr-only">
{{ modelValue ? 'Checked' : 'Unchecked' }}
{{ indeterminate ? __('Indeterminate') : (modelValue ? __('Checked') : __('Unchecked')) }}
</span>
</CheckboxRoot>
<div class="flex flex-col" v-if="!solo">
Expand Down