chore(deps) update PMD (java 25), fix resulting linter issues

Author: cgoetz-inovex

build.gradle

@@ -69,7 +69,7 @@ allprojects {
 
 	pmd {
 		consoleOutput = true
-		toolVersion = "7.12.0"
+		toolVersion = "7.20.0"
 
 		// This tells PMD to use your custom ruleset file.
 		ruleSetFiles = rootProject.files("config/pmd/pmd-ruleset.xml")

core/src/main/java/cloud/stackit/sdk/core/KeyFlowAuthenticator.java

@@ -19,7 +19,7 @@
 import java.security.NoSuchAlgorithmException;
 import java.security.interfaces.RSAPrivateKey;
 import java.security.spec.InvalidKeySpecException;
-import java.util.Date;
+import java.time.Instant;
 import java.util.Map;
 import java.util.UUID;
 import java.util.concurrent.ConcurrentHashMap;
@@ -200,7 +200,7 @@ public KeyFlowTokenResponse(
 		}
 
 		protected boolean isExpired() {
-			return expiresIn < new Date().toInstant().getEpochSecond();
+			return expiresIn < Instant.now().getEpochSecond();
 		}
 
 		protected String getAccessToken() {
@@ -342,8 +342,8 @@ private String generateSelfSignedJWT()
 				.withSubject(saKey.getCredentials().getSub())
 				.withJWTId(UUID.randomUUID().toString())
 				.withAudience(saKey.getCredentials().getAud())
-				.withIssuedAt(new Date())
-				.withExpiresAt(new Date().toInstant().plusSeconds(10 * 60))
+				.withIssuedAt(Instant.now())
+				.withExpiresAt(Instant.now().plusSeconds(10 * 60))
 				.withHeader(jwtHeader)
 				.sign(algorithm);
 	}

core/src/main/java/cloud/stackit/sdk/core/auth/SetupAuth.java

@@ -327,7 +327,7 @@ protected static String readValueFromCredentialsFile(
 		} catch (ClassCastException ignored) {
 		}
 		if (Utils.isStringSet(keyPath)) {
-			return new String(Files.readAllBytes(Paths.get(keyPath)));
+			return new String(Files.readAllBytes(Paths.get(keyPath)), StandardCharsets.UTF_8);
 		}
 		throw new CredentialsInFileNotFoundException(
 				"could not find " + valueKey + " or " + pathKey + " in " + path);

examples/alb/src/main/java/cloud/stackit/sdk/alb/examples/AlbExample.java

@@ -18,7 +18,6 @@ private AlbExample() {}
 		"PMD.CognitiveComplexity",
 		"PMD.CommentSize",
 		"PMD.CyclomaticComplexity",
-		"PMD.NPathComplexity",
 		"PMD.NcssCount",
 		"PMD.SystemPrintln",
 		"PMD.AvoidThrowingRawExceptionTypes"

examples/authentication/src/main/java/cloud/stackit/sdk/authentication/examples/AuthenticationExample.java

@@ -7,6 +7,7 @@
 import java.io.File;
 import java.io.FileNotFoundException;
 import java.io.IOException;
+import java.nio.charset.StandardCharsets;
 import java.util.Scanner;
 
 final class AuthenticationExample {
@@ -53,7 +54,7 @@ public static void main(String[] args) throws IOException {
 				"examples/authentication/src/main/java/cloud/stackit/sdk/authentication/examples/dummy_credentials/dummy-service-account-key.json";
 		File serviceAccountKeyFile = new File(serviceAccountKeyPath);
 		StringBuilder serviceAccountKeyContent = new StringBuilder();
-		try (Scanner myReader = new Scanner(serviceAccountKeyFile)) {
+		try (Scanner myReader = new Scanner(serviceAccountKeyFile, StandardCharsets.UTF_8.name())) {
 			while (myReader.hasNextLine()) {
 				serviceAccountKeyContent.append(myReader.nextLine());
 			}
@@ -66,7 +67,7 @@ public static void main(String[] args) throws IOException {
 				"examples/authentication/src/main/java/cloud/stackit/sdk/authentication/examples/dummy_credentials/dummy-private-key.pem";
 		File privateKeyFile = new File(privateKeyPath);
 		StringBuilder privateKeyContent = new StringBuilder();
-		try (Scanner myReader = new Scanner(privateKeyFile)) {
+		try (Scanner myReader = new Scanner(privateKeyFile, StandardCharsets.UTF_8.name())) {
 			while (myReader.hasNextLine()) {
 				privateKeyContent.append(myReader.nextLine());
 			}

examples/loadbalancer/src/main/java/cloud/stackit/sdk/loadbalancer/examples/LoadBalancerExample.java

@@ -18,7 +18,6 @@ private LoadBalancerExample() {}
 		"PMD.CognitiveComplexity",
 		"PMD.CommentSize",
 		"PMD.CyclomaticComplexity",
-		"PMD.NPathComplexity",
 		"PMD.NcssCount",
 		"PMD.SystemPrintln",
 		"PMD.AvoidThrowingRawExceptionTypes"

examples/objectstorage/src/main/java/cloud/stackit/sdk/objectstorage/examples/ObjectStorageExample.java

@@ -19,8 +19,6 @@ private ObjectStorageExample() {}
 
 	@SuppressWarnings({
 		"PMD.CyclomaticComplexity",
-		"PMD.CognitiveComplexity",
-		"PMD.NPathComplexity",
 		"PMD.NcssCount",
 		"PMD.SystemPrintln",
 		"PMD.AvoidThrowingRawExceptionTypes"

examples/resourcemanager/src/main/java/cloud/stackit/sdk/resourcemanager/examples/ResourcemanagerExample.java

@@ -24,7 +24,7 @@ final class ResourcemanagerExample {
 	/** Prevent instantiation */
 	private ResourcemanagerExample() {}
 
-	@SuppressWarnings({"PMD.SystemPrintln", "PMD.AvoidThrowingRawExceptionTypes"})
+	@SuppressWarnings({"PMD.SystemPrintln"})
 	public static void main(String[] args)
 			throws IOException, ApiException, InterruptedException, ExecutionException {
 		// Credentials are read from the credentialsFile in `~/.stackit/credentials.json` or the env

examples/serverupdate/src/main/java/cloud/stackit/sdk/serverupdate/examples/ServerUpdateExample.java

@@ -20,7 +20,6 @@ private ServerUpdateExample() {}
 	@SuppressWarnings({
 		"PMD.CyclomaticComplexity",
 		"PMD.CognitiveComplexity",
-		"PMD.NPathComplexity",
 		"PMD.NcssCount",
 		"PMD.SystemPrintln",
 		"PMD.AvoidThrowingRawExceptionTypes",

services/resourcemanager/src/main/java/cloud/stackit/sdk/resourcemanager/wait/ResourcemanagerWait.java

@@ -87,14 +87,12 @@ private static AsyncActionHandler<GetProjectResponse> createOrUpdateProjectWaitH
 				() -> {
 					GetProjectResponse projectResponse = apiClient.getProject(containerId, false);
 					if (projectResponse.getContainerId().equals(containerId)
-							&& projectResponse.getLifecycleState().equals(LifecycleState.ACTIVE)) {
+							&& projectResponse.getLifecycleState() == LifecycleState.ACTIVE) {
 						return new AsyncActionResult<>(true, projectResponse);
 					}
 
 					if (projectResponse.getContainerId().equals(containerId)
-							&& projectResponse
-									.getLifecycleState()
-									.equals(LifecycleState.CREATING)) {
+							&& projectResponse.getLifecycleState() == LifecycleState.CREATING) {
 						return new AsyncActionResult<>(false, null);
 					}
 					// An invalid state was received which should not be possible.
@@ -139,8 +137,7 @@ public static AsyncActionHandler<Void> deleteProjectWaitHandler(
 								apiClient.getProject(containerId, false);
 						if (projectResponse.getContainerId().equals(containerId)
 								&& projectResponse
-										.getLifecycleState()
-										.equals(LifecycleState.DELETING)) {
+										.getLifecycleState() == LifecycleState.DELETING) {
 							return new AsyncActionResult<>(true, null);
 						}