diff --git a/src/utils/nodeUtil.tsx b/src/utils/nodeUtil.tsx index c0b81106..ec3d5009 100644 --- a/src/utils/nodeUtil.tsx +++ b/src/utils/nodeUtil.tsx @@ -47,13 +47,11 @@ function convertItemsToNodes( if (type === 'divider') { return ; } - + const hasExtra = !!extra || extra === 0; return ( - {label} - {(!!extra || extra === 0) && ( - {extra} - )} + {hasExtra ? {label} : label} + {hasExtra && {extra}} ); } diff --git a/tests/__snapshots__/MenuItem.spec.tsx.snap b/tests/__snapshots__/MenuItem.spec.tsx.snap index dc957d18..c4e28718 100644 --- a/tests/__snapshots__/MenuItem.spec.tsx.snap +++ b/tests/__snapshots__/MenuItem.spec.tsx.snap @@ -22,7 +22,11 @@ exports[`MenuItem overwrite default role should set extra to group option 1`] = role="menuitem" tabindex="-1" > - Menu Item 1 + + Menu Item 1 + @@ -40,7 +44,11 @@ exports[`MenuItem overwrite default role should set extra to option 1`] = ` role="menuitem" tabindex="-1" > - Top Menu Item + + Top Menu Item +