gh-146194: Fix nested KeyboardInterrupt handling in asyncio#146203
Closed
okiemute04 wants to merge 5 commits intopython:mainfrom
Closed
gh-146194: Fix nested KeyboardInterrupt handling in asyncio#146203okiemute04 wants to merge 5 commits intopython:mainfrom
okiemute04 wants to merge 5 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146194
Problem
When multiple Ctrl+C presses occurred in nested asyncio tasks, the
third press would cause a crash with "Task was destroyed but it is pending!"
instead of gracefully cancelling the nested tasks.
Solution
Modified
_on_sigintinLib/asyncio/runners.pyto cancel the main taskon every SIGINT, allowing nested cancellations to propagate correctly
through multiple levels.
Testing
test_nested_keyboardinterrupt_handlingtotest_runners.py