From a6ee3ddc190f997d8cf5acd26b2015fe810e4b57 Mon Sep 17 00:00:00 2001 From: Lainow Date: Wed, 28 Jan 2026 12:20:34 +0100 Subject: [PATCH 1/4] Fix ITILSolution given error --- src/Controller.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Controller.php b/src/Controller.php index 34c4aa2..d4416b4 100644 --- a/src/Controller.php +++ b/src/Controller.php @@ -324,7 +324,7 @@ public static function preventClosure(CommonDBTM $item): void } } - public static function requireFieldsToClose(CommonITILObject $item): void + public static function requireFieldsToClose($item): void { $conf = Config::getConfig(); if ($conf->fields['is_active'] != 1) { From a11179c53b25843fd0dc5f3d64a25508b84fd3fc Mon Sep 17 00:00:00 2001 From: Lainow Date: Mon, 9 Feb 2026 15:07:22 +0100 Subject: [PATCH 2/4] Fix phpstan --- src/Controller.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Controller.php b/src/Controller.php index d4416b4..34c4aa2 100644 --- a/src/Controller.php +++ b/src/Controller.php @@ -324,7 +324,7 @@ public static function preventClosure(CommonDBTM $item): void } } - public static function requireFieldsToClose($item): void + public static function requireFieldsToClose(CommonITILObject $item): void { $conf = Config::getConfig(); if ($conf->fields['is_active'] != 1) { From 61d055342f5617a24db41ffde32200f7fc688624 Mon Sep 17 00:00:00 2001 From: Lainow Date: Tue, 10 Feb 2026 11:10:05 +0100 Subject: [PATCH 3/4] FIx lints --- src/Controller.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Controller.php b/src/Controller.php index 34c4aa2..859c788 100644 --- a/src/Controller.php +++ b/src/Controller.php @@ -38,6 +38,7 @@ namespace GlpiPlugin\Moreoptions; +use AltchaOrg\Altcha\Solution; use Change; use Change_Group; use Change_Item; @@ -324,7 +325,7 @@ public static function preventClosure(CommonDBTM $item): void } } - public static function requireFieldsToClose(CommonITILObject $item): void + public static function requireFieldsToClose(CommonDBTM $item): void { $conf = Config::getConfig(); if ($conf->fields['is_active'] != 1) { @@ -336,8 +337,8 @@ public static function requireFieldsToClose(CommonITILObject $item): void // Determine the configuration suffix and actor classes based on item type $configSuffix = '_' . strtolower($itemtype); - $userClass = $item->userlinkclass; - $groupClass = $item->grouplinkclass; + $userClass = $item->userlinkclass ?? ''; + $groupClass = $item->grouplinkclass ?? ''; $itemIdField = $item->getForeignKeyField(); // Check for required technician From f4d3e2be130256b160e78b3c5c704b84d9058308 Mon Sep 17 00:00:00 2001 From: Samuel Launay <107540223+Lainow@users.noreply.github.com> Date: Tue, 10 Feb 2026 11:32:39 +0100 Subject: [PATCH 4/4] Update src/Controller.php Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com> --- src/Controller.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Controller.php b/src/Controller.php index 859c788..709f880 100644 --- a/src/Controller.php +++ b/src/Controller.php @@ -38,7 +38,6 @@ namespace GlpiPlugin\Moreoptions; -use AltchaOrg\Altcha\Solution; use Change; use Change_Group; use Change_Item;