Fix Solaris tests and enable CI by psumbera · Pull Request #20709 · php/php-src

psumbera · 2025-12-15T13:42:44Z

No description provided.

devnexen · 2025-12-15T20:43:58Z

cc @iluuu1994 at least for the CI's aspect.

devnexen · 2025-12-15T20:46:25Z

ext/pcntl/tests/pcntl_cpuaffinity.phpt

 --SKIPIF--
 <?php
 if (!function_exists("pcntl_setcpuaffinity")) die("skip pcntl_setcpuaffinity is not available");
+if (PHP_OS_FAMILY === 'Solaris') die("skip CPU affinity not supported on Solaris");


is the test failing and in which manner ? because as far as I see it is supported by solaris.

It fails like this:

Running selected tests. TEST 1/1 [ext/pcntl/tests/pcntl_cpuaffinity.phpt] ========DIFF======== 001- bool(true) 002- array(0) { 003- } 004- array(0) { 005- } 006- bool(true) 007- pcntl_setcpuaffinity(): Argument #2 ($cpu_ids) must not be empty 008- pcntl_setcpuaffinity(): Argument #2 ($cpu_ids) cpu id invalid value (def) 009- pcntl_setcpuaffinity(): Argument #2 ($cpu_ids) cpu id must be between 0 and %d (%d) 010- pcntl_setcpuaffinity(): Argument #2 ($cpu_ids) cpu id must be between 0 and %d (-1024) 011- pcntl_getcpuaffinity(): Argument #1 ($process_id) invalid process (-1024) 012- pcntl_setcpuaffinity(): Argument #2 ($cpu_ids) value must be of type int|string, array given 001+ Warning: pcntl_setcpuaffinity(): pset_create: Cannot allocate memory in /root/php-src/ext/pcntl/tests/pcntl_cpuaffinity.php on line 3 002+ bool(false) 003+ 004+ Warning: pcntl_getcpuaffinity(): pset_create: Cannot allocate memory in /root/php-src/ext/pcntl/tests/pcntl_cpuaffinity.php on line 4 005+ 006+ Fatal error: Uncaught TypeError: array_diff(): Argument #2 must be of type array, false given in /root/php-src/ext/pcntl/tests/pcntl_cpuaffinity.php:5 007+ Stack trace: 008+ #0 /root/php-src/ext/pcntl/tests/pcntl_cpuaffinity.php(5): array_diff(Array, false) 009+ #1 {main} 010+ thrown in /root/php-src/ext/pcntl/tests/pcntl_cpuaffinity.php on line 5 ========DONE======== FAIL pcntl_getcpuaffinity() and pcntl_setcpuaffinity() [ext/pcntl/tests/pcntl_cpuaffinity.phpt]

the test might need adaptation rather than disabling it, pset_create seems to set errno to ENOMEM here. We can devise about it later..

btw do you run it under a VM ? curious also what psrset gives

btw do you run it under a VM ? curious also what psrset gives

Yes, it's VM. When I run test on real machine I get:

========DIFF======== -- pcntl_setcpuaffinity(): Argument #2 ($cpu_ids) cpu id invalid value (def) pcntl_setcpuaffinity(): Argument #2 ($cpu_ids) cpu id must be between 0 and %d (%d) pcntl_setcpuaffinity(): Argument #2 ($cpu_ids) cpu id must be between 0 and %d (-1024) 011- pcntl_getcpuaffinity(): Argument #1 ($process_id) invalid process (-1024) pcntl_setcpuaffinity(): Argument #2 ($cpu_ids) value must be of type int|string, array given ========DONE======== FAIL pcntl_getcpuaffinity() and pcntl_setcpuaffinity() [ext/pcntl/tests/pcntl_cpuaffinity.phpt]

I don't see difference in psrset output between VM and real machine. Both give lines like:

processor set SYSpsrset_1 1: empty ..

Ok that should be largely enough, when I implemented this feature, it I just used a openindiana VM with only 8GB.
That might be swap space issue ; I guess you re really booting a 64 bits kernel.
That would be sad to disable this test just because of particular environment context.

Ok, there is something wrong with VM. Another one doesn't have the problem.

Not sure about this one. For now I left it disabled:

TEST 1/1 [ext/pcntl/tests/pcntl_getcpu.phpt] ========DIFF======== bool(true) 002- int(1) 002+ int(2) ========DONE======== FAIL pcntl_getcpu() [ext/pcntl/tests/pcntl_getcpu.phpt]

this one issue seems real at first glance, the test should not even launch on solaris/illumos. Is HAVE_SCHED_GETCPU commented in your main/php_config.h ?

Yes, it is (/* #undef HAVE_SCHED_GETCPU */).

devnexen · 2025-12-15T20:47:16Z

ext/opcache/shared_alloc_shm.c

 # define MIN(x, y) ((x) > (y)? (y) : (x))
 #endif

-#define SEG_ALLOC_SIZE_MAX 32*1024*1024


it seems a slightly unrelated change to me (I do not say it is right or wrong tough).

On Solaris, OPcache uses the SysV SHM allocator (shared_alloc_shm.c), which hard-limits individual segments to 32 MB (SEG_ALLOC_SIZE_MAX). With JIT enabled, OPcache reserves a default 64 MB buffer (ZEND_JIT_DEFAULT_BUFFER_SIZE) from the last shared segment during zend_shared_alloc_startup(). This makes startup fail with “Insufficient shared memory!” because the last segment can never satisfy the reservation.

sure, but what I understood from the comment is opcache on solaris can't work without this change ? If that is the case, this change needs to be a PR on its own as a bug fix (from the lowest branch it needs to apply).

I have created #20719 .

.github/actions/solaris/action.yml

trusting the call to handle invalid process id via errnos. see #20709 (comment) for rationale. close GH-20731

ext/date/lib/parse_date.c

.github/actions/solaris/action.yml

psumbera · 2026-02-10T08:14:10Z

I believe this should be now ready to go.

sapi/cli/tests/cli_process_title_unix.phpt

ext/standard/tests/time/strptime_basic.phpt

ext/standard/tests/strings/setlocale_variation1.phpt

ext/date/tests/bug33532.phpt

iluuu1994 · 2026-02-10T13:30:09Z

ext/pcntl/tests/pcntl_cpuaffinity.phpt

 <?php
+if (getenv("SKIP_BROKEN_PSET_CREATE")) {
+    die("skip broken pset_create()");
+}


Why is this excluded specially, rather than with usual the PHP_OS_FAMILY === 'Solaris' check?

I think the reason was that this might work sometimes. Maybe for Illumos?

.github/workflows/root.yml

.github/workflows/push.yml

.github/actions/solaris/action.yml

.github/workflows/nightly.yml

psumbera · 2026-03-02T08:25:22Z

I believe everything was resolved here. What shall be done now in order to merge this change?

iluuu1994 · 2026-03-02T10:24:01Z

@psumbera There were big changes in CI. I can resolve the conflicts for you. After that I'll do another review.

Closes phpGH-20709

psumbera requested review from TimWolla, bukka, derickr, devnexen, dstogov, kamil-tekiela and ndossche as code owners December 15, 2025 13:42

psumbera force-pushed the github-solaris-ci branch 2 times, most recently from bbc1c07 to 9c9436d Compare December 15, 2025 14:17

devnexen reviewed Dec 15, 2025

View reviewed changes

.github/actions/solaris/action.yml Outdated Show resolved Hide resolved

psumbera force-pushed the github-solaris-ci branch from 9c9436d to 924f86d Compare December 16, 2025 09:59

devnexen added a commit that referenced this pull request Dec 24, 2025

ext/pcntl: fix pcntl_getcpuaffinity() for solaris.

5faa54d

trusting the call to handle invalid process id via errnos. see #20709 (comment) for rationale. close GH-20731

psumbera force-pushed the github-solaris-ci branch 2 times, most recently from 3971a8f to db47277 Compare January 7, 2026 10:11

derickr requested changes Jan 13, 2026

View reviewed changes

ext/date/lib/parse_date.c Outdated Show resolved Hide resolved

psumbera force-pushed the github-solaris-ci branch from db47277 to eb04fc5 Compare January 26, 2026 13:19

psumbera force-pushed the github-solaris-ci branch 2 times, most recently from e711432 to 58ee7f0 Compare February 9, 2026 15:51

iluuu1994 reviewed Feb 9, 2026

View reviewed changes

.github/actions/solaris/action.yml Show resolved Hide resolved

psumbera force-pushed the github-solaris-ci branch 2 times, most recently from 998f8ba to 97b36c0 Compare February 9, 2026 19:24

psumbera requested a review from derickr February 10, 2026 08:12

iluuu1994 reviewed Feb 10, 2026

View reviewed changes

psumbera force-pushed the github-solaris-ci branch 2 times, most recently from e9808d1 to 7ba6892 Compare February 11, 2026 17:31

iluuu1994 reviewed Feb 11, 2026

View reviewed changes

.github/workflows/nightly.yml Outdated Show resolved Hide resolved

psumbera force-pushed the github-solaris-ci branch from 7ba6892 to d4d0613 Compare February 11, 2026 19:41

iluuu1994 force-pushed the github-solaris-ci branch from d4d0613 to 3b758f3 Compare March 2, 2026 22:23

iluuu1994 added CI: No jobs CI: Solaris labels Mar 2, 2026

iluuu1994 force-pushed the github-solaris-ci branch 2 times, most recently from 32fe148 to f12d59c Compare March 2, 2026 22:26

Fix Solaris tests and and nightly CI job

83a1136

Closes phpGH-20709

iluuu1994 force-pushed the github-solaris-ci branch from f12d59c to e23292d Compare March 2, 2026 22:44

iluuu1994 added 2 commits March 3, 2026 00:10

Disable -Wchar-subscripts, enable -Werror

b74d875

Fix -Wabsolute-value

8a8099f

iluuu1994 force-pushed the github-solaris-ci branch from e23292d to 8a8099f Compare March 2, 2026 23:12

github-actions bot added the Extension: soap label Mar 2, 2026

Conversation

psumbera commented Dec 15, 2025

Uh oh!

devnexen commented Dec 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devnexen Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devnexen Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devnexen Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

psumbera Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devnexen Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devnexen Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

psumbera commented Feb 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

psumbera commented Mar 2, 2026

Uh oh!

iluuu1994 commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

devnexen Dec 18, 2025 •

edited

Loading

devnexen Dec 19, 2025 •

edited

Loading

devnexen Dec 19, 2025 •

edited

Loading

psumbera Dec 19, 2025 •

edited

Loading

devnexen Dec 15, 2025 •

edited

Loading

devnexen Dec 16, 2025 •

edited

Loading