Skip to content

Commit ff962ba

Browse files
committed
simplify
1 parent c792390 commit ff962ba

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

binding.cc

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -828,20 +828,17 @@ NAPI_METHOD(db_open) {
828828
uint32_t len;
829829
NAPI_STATUS_THROWS(napi_get_array_length(env, keys, &len));
830830

831+
columnsFamilies.resize(len);
831832
for (uint32_t n = 0; n < len; ++n) {
832833
napi_value key;
833834
NAPI_STATUS_THROWS(napi_get_element(env, keys, n, &key));
834835

835836
napi_value column;
836837
NAPI_STATUS_THROWS(napi_get_property(env, columns, key, &column));
837838

838-
rocksdb::ColumnFamilyOptions columnOptions;
839-
NAPI_STATUS_THROWS(InitOptions(env, columnOptions, column));
839+
NAPI_STATUS_THROWS(InitOptions(env, columnsFamilies[n].options, column));
840840

841-
std::string name;
842-
NAPI_STATUS_THROWS(ToString(env, key, name));
843-
844-
columnsFamilies.emplace_back(std::move(name), std::move(columnOptions));
841+
NAPI_STATUS_THROWS(ToString(env, key, columnsFamilies[n].name));
845842
}
846843
}
847844

0 commit comments

Comments
 (0)