[SM6.10][specs/791] Align LinAlg Matrix Mul with spec#8183
Merged
Conversation
microsoft/hlsl-specs#791 splits the MulOp operation into two distinct ops. Update the implementation to reflect that
spall
reviewed
Feb 20, 2026
| "o,o,o,o", | ||
| "", | ||
| [ | ||
| db_dxil_param(0, "$x0", "", "resulting matrix"), |
Collaborator
There was a problem hiding this comment.
is skipping over 1 intentional?
Collaborator
Author
There was a problem hiding this comment.
Yep! 1 is the const int opcode which is inserted automatically
| "applies a multiplication op to matrix C using A and B as parameters", | ||
| "LinAlgMatrixMultiply", | ||
| "LinAlgMatrixMultiply", | ||
| "Returns the resulting matrix from multiplying A and B", |
Collaborator
There was a problem hiding this comment.
this one doesn't need db_dxil_params?
Collaborator
Author
There was a problem hiding this comment.
It has them just below the diff!
The params of this op didn't change, just the name as description
inbelic
approved these changes
Feb 20, 2026
spall
approved these changes
Feb 20, 2026
damyanp
approved these changes
Feb 20, 2026
luciechoi
pushed a commit
to luciechoi/DirectXShaderCompiler
that referenced
this pull request
Feb 20, 2026
microsoft/hlsl-specs#791 splits the MulOp operation into two distinct ops. Update the placeholder code to reflect that. Interesting changes are in `gen_intrin_main`, `hctdb.py`, and `HLOperationLower.cpp`. The rest of the code is generated code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/hlsl-specs#791 splits the MulOp operation into two distinct ops. Update the placeholder code to reflect that.
Interesting changes are in
gen_intrin_main,hctdb.py, andHLOperationLower.cpp. The rest of the code is generated code