-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Description
Describe the bug
Current Behavior
After the qs upgrade in commit 1eedfd5 (to address GHSA-6rw7-vpxm-498p), query parameter arrays with more than 20 items are being converted to objects with numeric keys instead of arrays. This causes LoopBack's parameter validation to fail.
Expected Behavior
Query parameters in the format ?ids=1&ids=2&ids=3...&ids=25 should be parsed as an array regardless of the number of items (within reasonable limits).
Steps to Reproduce
Create an endpoint with an array parameter:
typescript@get('/test')
async test(
@param.array('ids', 'query', { type: 'string' })
ids: string[]
): Promise<any> {
return { ids };
}
- Make a request with 21+ repeated query parameters:
GET /test?ids=1&ids=2&ids=3...&ids=21&ids=22
Observe the validation error:
json{
"error": {
"statusCode": 400,
"name": "BadRequestError",
"message": "Invalid data [{\"0\":\"1\",\"1\":\"2\",...}] for parameter \"ids\".",
"code": "INVALID_PARAMETER_VALUE"
}
}
Root Cause
The qs library by default limits array indices to 20 (https://github.com/ljharb/qs#parsing-arrays). When more than 20 items are provided, it converts the array to an object with numeric keys to prevent DoS attacks with extremely large indices like a[999999999].
This is documented behavior in the qs library, and there is an ongoing discussion about this limitation, since it was introduced in a patch version instead of a breaking change version: ljharb/qs#537
Impact
This breaks existing APIs that accept more than 20 array items via query parameters.
Proposed Solution
Configure qs with a higher arrayLimit option. The default of 20 is too restrictive.
I encourage the LoopBack team to contribute to the discussion in the qs issue thread (ljharb/qs#537) to help get this resolved at the library level, and in the meantime provide a way for LoopBack applications to configure this limit.
Suggested approaches for LoopBack:
Make arrayLimit configurable via RestServer options so applications can set their own limits
Increase the default arrayLimit to a more reasonable value (e.g., 100 or 1000)
Document the workaround for applications that need to handle this
LoopBack version: 4.x (any version after the qs upgrade)
Node.js version: [applicable to all]
Operating system: [applicable to all]
Additional Context
Related CVE fix: GHSA-6rw7-vpxm-498p
qs documentation: https://github.com/ljharb/qs#parsing-arrays
Ongoing discussion in qs repo: ljharb/qs#537
Logs
Additional information
No response