Conversation
alexrashed
approved these changes
Nov 20, 2024
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Great catch! 3.7 has EOL for a long time already, so it's definitely safe to remove support on our end as well! Thanks for adding the additional new versions and the workflow dispatch trigger! 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Boto3 no longer explicitly support python 3.7 and lower, so it seems fair to remove it from our ci and pypi package.
Also adding support for newer version of python and a
workflow_dispatchto allow triggering the the ci manually.