fix: fix notification bubble animation glitch#1537
Open
mhduiy wants to merge 1 commit intolinuxdeepin:masterfrom
Open
fix: fix notification bubble animation glitch#1537mhduiy wants to merge 1 commit intolinuxdeepin:masterfrom
mhduiy wants to merge 1 commit intolinuxdeepin:masterfrom
Conversation
1. Replaced the previous complex ScriptAction with a simpler PropertyAnimation for the add transition 2. Added a new addDisplaced transition to handle displaced items when new notifications are added 3. Removed the manual script that forced previous bubble animations to complete, which was causing visual glitches 4. Now uses standard Qt Quick transitions for smoother and more reliable animation behavior fix: 修复通知气泡动画显示问题 1. 将之前复杂的 ScriptAction 替换为更简单的 PropertyAnimation 来处理添加 动画 2. 新增 addDisplaced 过渡动画来处理新通知添加时其他气泡的位移 3. 移除了强制完成前一个气泡动画的手动脚本,该脚本会导致视觉故障 4. 现在使用标准的 Qt Quick 过渡动画来实现更平滑可靠的动画效果 PMS: BUG-355029
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors the notification bubble list add animation to use standard Qt Quick PropertyAnimation transitions, and adds a dedicated addDisplaced transition to smoothly reposition existing bubbles when new notifications are inserted, removing the previous manual ScriptAction hack that caused glitches. Sequence diagram for updated notification bubble add animationsequenceDiagram
actor User
participant App
participant NotificationModel
participant bubbleView
participant addTrans
participant addDisplacedTrans
User->>App: Triggers event that creates notification
App->>NotificationModel: appendNotification()
NotificationModel-->>bubbleView: modelUpdated (new item)
bubbleView->>addTrans: start add Transition
activate addTrans
addTrans->>addTrans: PropertyAnimation on item.x
addTrans-->>bubbleView: item slides in from width to 0
deactivate addTrans
bubbleView->>addDisplacedTrans: start addDisplaced Transition
activate addDisplacedTrans
addDisplacedTrans->>addDisplacedTrans: PropertyAnimation on displaced items x
addDisplacedTrans-->>bubbleView: existing bubbles reposition smoothly
deactivate addDisplacedTrans
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
18202781743
approved these changes
Mar 30, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: 修复通知气泡动画显示问题
PMS: BUG-355029
Summary by Sourcery
Simplify and standardize notification bubble list transitions to fix animation glitches when new notifications are added.
Bug Fixes:
Enhancements: