fix validation of nullable params when empty

Author: ezekg

lib/typed_params/validator.rb

@@ -6,7 +6,7 @@ module TypedParams
   class Validator < Mapper
     def call(params)
       raise InvalidParameterError.new('is missing', path: schema.path, source: schema.source) if
-        params.nil? && schema.required? && !schema.allow_nil?
+        params.nil? && schema.required?
 
       depth_first_map(params) do |param|
         schema = param.schema

spec/typed_params/validator_spec.rb

@@ -53,6 +53,21 @@
     expect { validator.call(params) }.to_not raise_error
   end
 
+  it 'should raise on missing nested required params' do
+    schema = TypedParams::Schema.new(type: :hash) do
+      param :foo, type: :hash do
+        param :bar, type: :hash do
+          param :baz, type: :string
+        end
+      end
+    end
+
+    params    = TypedParams::Parameterizer.new(schema:).call(value: { foo: {} })
+    validator = TypedParams::Validator.new(schema:)
+
+    expect { validator.call(params) }.to raise_error TypedParams::InvalidParameterError
+  end
+
   it 'should not raise on missing nested optional params' do
     schema = TypedParams::Schema.new(type: :hash) do
       param :foo, type: :hash do
@@ -68,6 +83,21 @@
     expect { validator.call(params) }.to_not raise_error
   end
 
+  it 'should raise on missing nested nilable params' do
+    schema = TypedParams::Schema.new(type: :hash) do
+      param :foo, type: :hash do
+        param :bar, type: :hash, allow_nil: true do
+          param :baz, type: :string
+        end
+      end
+    end
+
+    params    = TypedParams::Parameterizer.new(schema:).call(value: { foo: {} })
+    validator = TypedParams::Validator.new(schema:)
+
+    expect { validator.call(params) }.to raise_error TypedParams::InvalidParameterError
+  end
+
   it 'should raise on missing required param' do
     schema    = TypedParams::Schema.new(type: :hash) { param :foo, type: :string, optional: false }
     params    = TypedParams::Parameterizer.new(schema:).call(value: {})
@@ -377,6 +407,14 @@
     expect { validator.call(params) }.to_not raise_error
   end
 
+  it 'should not raise on empty array' do
+    schema    = TypedParams::Schema.new(type: :array)
+    params    = TypedParams::Parameterizer.new(schema:).call(value: [])
+    validator = TypedParams::Validator.new(schema:)
+
+    expect { validator.call(params) }.to_not raise_error
+  end
+
   it 'should raise on array of non-scalar values' do
     schema    = TypedParams::Schema.new(type: :array)
     params    = TypedParams::Parameterizer.new(schema:).call(value: [1, 2, [3]])
@@ -393,6 +431,32 @@
     expect { validator.call(params) }.to_not raise_error
   end
 
+  it 'should not raise on array of objects' do
+    schema = TypedParams::Schema.new type: :array do
+      items type: :hash do
+        param :key, type: :string
+      end
+    end
+
+    params    = TypedParams::Parameterizer.new(schema:).call(value: [key: 'value'])
+    validator = TypedParams::Validator.new(schema:)
+
+    expect { validator.call(params) }.to_not raise_error
+  end
+
+  it 'should not raise on empty array of objects' do
+    schema = TypedParams::Schema.new type: :array do
+      items type: :hash do
+        param :key, type: :string
+      end
+    end
+
+    params    = TypedParams::Parameterizer.new(schema:).call(value: [])
+    validator = TypedParams::Validator.new(schema:)
+
+    expect { validator.call(params) }.to_not raise_error
+  end
+
   context 'with config to not ignore optional nils' do
     before do
       @ignore_nil_optionals_was = TypedParams.config.ignore_nil_optionals
@@ -521,4 +585,4 @@
       expect { validator.call(params) }.to raise_error TypedParams::InvalidParameterError
     end
   end
-end
+end