Typo in Flask view context

[jahs]

Hi all, just a small one:

The line

graphql-server/src/graphql_server/flask/views.py

Line 145 in 2d5ac95

operationName=request_data.operation_name,

creates the context with operationName but the template

graphql-server/src/graphql_server/static/graphiql.html

Line 199 in 2d5ac95

operationName: {{operation_name}},

expects operation_name. Probably request_data.to_template_context() is meant to be used which does use operation_name:

graphql-server/src/graphql_server/http/__init__.py

Line 74 in 2d5ac95

"operation_name": tojson(self.operation_name),

Thanks!

[tking2]

Spotting bigger issues than just the operation_name variable.

https://github.com/graphql-python/graphql-server/blob/main/src/graphql_server/static/graphiql.html#L187C42-L187C55

locationQuery has been removed from this file, but we're still seeing a reference here.

I'm pinned to 3.0.0b7 while 3.0.0 is still unstable.

[jahs]

Hi, thanks for looking at this. Also related is I get an issue with html escaping when using to_template_context(), as in

graphql-server/src/graphql_server/static/graphiql.html

Line 197 in 2d5ac95

variables: {{variables}},

the JSON string isn't marked as safe, so gets escaped to eg "". Can be fixed with markupsafe.Markup(tojson(.... at

graphql-server/src/graphql_server/http/__init__.py

Line 71 in 2d5ac95

"variables": tojson(

or amending the template (unsure about frameworks other than Flask, however). Thanks!

[leonardwellthy]

I submitted a PR to fix these issues: #138 but I have no idea what it takes to get a review!