chore: addressing code review

Author: bcoe

static/app/views/nav/orgDropdown.spec.tsx

@@ -3,8 +3,10 @@ import {UserFixture} from 'sentry-fixture/user';
 
 import {render, screen, userEvent, within} from 'sentry-test/reactTestingLibrary';
 
+import {CUSTOM_REFERRER_KEY} from 'sentry/constants';
 import ConfigStore from 'sentry/stores/configStore';
 import OrganizationsStore from 'sentry/stores/organizationsStore';
+import sessionStorage from 'sentry/utils/sessionStorage';
 import {OrgDropdown} from 'sentry/views/nav/orgDropdown';
 
 describe('OrgDropdown', () => {
@@ -102,4 +104,16 @@ describe('OrgDropdown', () => {
       within(inactiveGroup).getByRole('menuitemradio', {name: /Deleting org/})
     ).toBeInTheDocument();
   });
+
+  it('clicking project sets referrer in session storage', async () => {
+    render(<OrgDropdown />, {organization});
+    await userEvent.click(screen.getByRole('button', {name: 'Toggle organization menu'}));
+    // We use onAction to navigate, no href is set:
+    expect(screen.getByRole('menuitemradio', {name: 'Projects'})).not.toHaveAttribute(
+      'href'
+    );
+    // onClick should take precedence setting session storage value and navigating:
+    await userEvent.click(screen.getByRole('menuitemradio', {name: 'Projects'}));
+    expect(sessionStorage.getItem(CUSTOM_REFERRER_KEY)).toBe('"org-dropdown"');
+  });
 });

static/gsApp/utils/rawTrackAnalyticsEvent.spec.tsx

@@ -187,7 +187,7 @@ describe('rawTrackAnalyticsEvent', () => {
   });
 
   it('sets custom_referrer if found in local storage', () => {
-    sessionStorage.setItem(CUSTOM_REFERRER_KEY, 'batman');
+    sessionStorage.setItem(CUSTOM_REFERRER_KEY, JSON.stringify('batman'));
     setWindowLocation('http:/localhost');
     rawTrackAnalyticsEvent({
       eventKey: 'test_event',

static/gsApp/utils/rawTrackAnalyticsEvent.tsx

@@ -82,7 +82,7 @@ const getCustomReferrer = () => {
       sessionStorage.getItem(CUSTOM_REFERRER_KEY) &&
       typeof sessionStorage.getItem(CUSTOM_REFERRER_KEY) === 'string'
     ) {
-      const sessionReferrer = sessionStorage.getItem(CUSTOM_REFERRER_KEY);
+      const sessionReferrer = JSON.parse(sessionStorage.getItem(CUSTOM_REFERRER_KEY));
       sessionStorage.removeItem(CUSTOM_REFERRER_KEY);
       return sessionReferrer;
     }