[flow] Upgrade from 0.279 -> 0.280

Flow 0.280 introduced stricter type checking for `incompatible-type` errors,
requiring additional $FlowFixMe suppressions alongside existing ones. Changes:

- Made `QueuingStrategy` properties optional in streams.js
- Made all properties optional in Web Animations API types (EffectTiming,
  KeyframeAnimationOptions, etc.)
- Added `$FlowFixMe[incompatible-type]` alongside existing suppressions in
  multiple files where Flow now reports additional type mismatches

Author: poteto

flow-typed/environments/streams.js

@@ -78,8 +78,8 @@ type PipeToOptions = {
 };
 
 type QueuingStrategy = {
-  highWaterMark: number,
-  size(chunk: ?any): number,
+  highWaterMark?: number,
+  size?: (chunk: ?any) => number,
   ...
 };
 

flow-typed/environments/web-animations.js

@@ -29,22 +29,22 @@ type AnimationPlaybackEvent$Init = Event$Init & {
 };
 
 type BaseComputedKeyframe = {|
-  composite: CompositeOperationOrAuto,
-  computedOffset: number,
-  easing: string,
-  offset: number | null,
+  composite?: CompositeOperationOrAuto,
+  computedOffset?: number,
+  easing?: string,
+  offset?: number | null,
 |};
 
 type BaseKeyframe = {|
-  composite: CompositeOperationOrAuto,
-  easing: string,
-  offset: number | null,
+  composite?: CompositeOperationOrAuto,
+  easing?: string,
+  offset?: number | null,
 |};
 
 type BasePropertyIndexedKeyframe = {|
-  composite: CompositeOperationOrAuto | Array<CompositeOperationOrAuto>,
-  easing: string | Array<string>,
-  offset: number | null | Array<number | null>,
+  composite?: CompositeOperationOrAuto | Array<CompositeOperationOrAuto>,
+  easing?: string | Array<string>,
+  offset?: number | null | Array<number | null>,
 |};
 
 type ComputedEffectTiming = {|
@@ -67,28 +67,33 @@ type DocumentTimelineOptions = {|
 |};
 
 type EffectTiming = {|
-  direction: PlaybackDirection,
-  easing: string,
-  fill: FillMode,
-  iterations: number,
-  iterationStart: number,
+  direction?: PlaybackDirection,
+  easing?: string,
+  fill?: FillMode,
+  iterations?: number,
+  iterationStart?: number,
+  delay?: number,
+  duration?: number | string,
+  endDelay?: number,
 |};
 
 type GetAnimationsOptions = {|
-  pseudoElement: string | null,
-  subtree: boolean,
+  pseudoElement?: string | null,
+  subtree?: boolean,
 |};
 
 type KeyframeAnimationOptions = {|
   ...KeyframeEffectOptions,
-  id: string,
-  timeline: AnimationTimeline | null,
+  id?: string,
+  timeline?: AnimationTimeline | null,
+  rangeStart?: string,
+  rangeEnd?: string,
 |};
 
 type KeyframeEffectOptions = {|
   ...EffectTiming,
-  composite: CompositeOperation,
-  pseudoElement: string | null,
+  composite?: CompositeOperation,
+  pseudoElement?: string | null,
 |};
 
 type Keyframe = {

package.json

@@ -75,8 +75,8 @@
     "eslint-plugin-react-internal": "link:./scripts/eslint-rules",
     "fbjs-scripts": "^3.0.1",
     "filesize": "^6.0.1",
-    "flow-bin": "^0.279.0",
-    "flow-remove-types": "^2.279.0",
+    "flow-bin": "^0.280.0",
+    "flow-remove-types": "^2.280.0",
     "flow-typed": "^4.1.1",
     "glob": "^7.1.6",
     "glob-stream": "^6.1.0",

packages/internal-test-utils/internalAct.js

@@ -165,6 +165,7 @@ export async function act<T>(scope: () => Thenable<T>): Thenable<T> {
     }
 
     // $FlowFixMe[incompatible-return]
+    // $FlowFixMe[incompatible-type]
     return result;
   } finally {
     const depth = actingUpdatesScopeDepth;
@@ -287,6 +288,7 @@ export async function serverAct<T>(scope: () => Thenable<T>): Thenable<T> {
     }
 
     // $FlowFixMe[incompatible-return]
+    // $FlowFixMe[incompatible-type]
     return result;
   } finally {
     if (typeof process === 'object') {

packages/react-client/src/ReactFlightClient.js

@@ -720,6 +720,7 @@ function triggerErrorOnChunk<T>(
     const streamChunk: InitializedStreamChunk<any> = (chunk: any);
     const controller = streamChunk.reason;
     // $FlowFixMe[incompatible-call]: The error method should accept mixed.
+    // $FlowFixMe[incompatible-type]
     controller.error(error);
     return;
   }
@@ -3207,6 +3208,7 @@ function startReadableStream<T>(
     error(error: mixed): void {
       if (previousBlockedChunk === null) {
         // $FlowFixMe[incompatible-call]
+        // $FlowFixMe[incompatible-type]
         controller.error(error);
       } else {
         const blockedChunk = previousBlockedChunk;

packages/react-client/src/ReactFlightReplyClient.js

@@ -535,6 +535,7 @@ export function processReply(
 
       if (isArray(value)) {
         // $FlowFixMe[incompatible-return]
+        // $FlowFixMe[incompatible-type]
         return value;
       }
       // TODO: Should we the Object.prototype.toString.call() to test for cross-realm objects?
@@ -552,6 +553,7 @@ export function processReply(
         // $FlowFixMe[prop-missing]: FormData has forEach.
         value.forEach((originalValue: string | File, originalKey: string) => {
           // $FlowFixMe[incompatible-call]
+          // $FlowFixMe[incompatible-type]
           data.append(prefix + originalKey, originalValue);
         });
         return serializeFormDataReference(refId);
@@ -829,6 +831,7 @@ export function processReply(
     }
     modelRoot = model;
     // $FlowFixMe[incompatible-return] it's not going to be undefined because we'll encode it.
+    // $FlowFixMe[incompatible-type]
     return JSON.stringify(model, resolveToJSON);
   }
 
@@ -855,6 +858,7 @@ export function processReply(
     formData.set(formFieldPrefix + '0', json);
     if (pendingParts === 0) {
       // $FlowFixMe[incompatible-call] this has already been refined.
+      // $FlowFixMe[incompatible-type]
       resolve(formData);
     }
   }
@@ -934,6 +938,7 @@ function defaultEncodeFormAction(
     // $FlowFixMe[prop-missing]
     encodedFormData.forEach((value: string | File, key: string) => {
       // $FlowFixMe[incompatible-call]
+      // $FlowFixMe[incompatible-type]
       prefixedData.append('$ACTION_' + identifierPrefix + ':' + key, value);
     });
     data = prefixedData;
@@ -1184,6 +1189,7 @@ function bind(this: Function): Function {
 
   if (!referenceClosure) {
     // $FlowFixMe[incompatible-call]
+    // $FlowFixMe[incompatible-type]
     return FunctionBind.apply(this, arguments);
   }
 

packages/react-debug-tools/src/ReactDebugHooks.js

@@ -726,9 +726,11 @@ function useActionState<S, P>(
 
 function useHostTransitionStatus(): TransitionStatus {
   const status = readContext<TransitionStatus>(
+    // $FlowFixMe[incompatible-type]
     // $FlowFixMe[prop-missing] `readContext` only needs _currentValue
     ({
       // $FlowFixMe[incompatible-cast] TODO: Incorrect bottom value without access to Fiber config.
+      // $FlowFixMe[incompatible-type]
       _currentValue: null,
     }: ReactContext<TransitionStatus>),
   );

packages/react-devtools-core/src/backend.js

@@ -188,7 +188,7 @@ export function connectToDevTools(options: ?ConnectOptions) {
     }
 
     // TODO (npm-packages) Warn if "isBackendStorageAPISupported"
-    // $FlowFixMe[incompatible-call] found when upgrading Flow
+    // $FlowFixMe[incompatible-type] found when upgrading Flow
     const agent = new Agent(bridge, isProfiling, onReloadAndProfile);
     if (typeof onReloadAndProfileFlagsReset === 'function') {
       onReloadAndProfileFlagsReset();
@@ -212,7 +212,7 @@ export function connectToDevTools(options: ?ConnectOptions) {
     // Setup React Native style editor if the environment supports it.
     if (resolveRNStyle != null || hook.resolveRNStyle != null) {
       setupNativeStyleEditor(
-        // $FlowFixMe[incompatible-call] found when upgrading Flow
+        // $FlowFixMe[incompatible-type] found when upgrading Flow
         bridge,
         agent,
         ((resolveRNStyle || hook.resolveRNStyle: any): ResolveNativeStyle),

packages/react-devtools-core/src/standalone.js

@@ -265,7 +265,7 @@ function initialize(socket: WebSocket) {
     socket.close();
   });
 
-  // $FlowFixMe[incompatible-call] found when upgrading Flow
+  // $FlowFixMe[incompatible-type] found when upgrading Flow
   store = new Store(bridge, {
     checkBridgeProtocolCompatibility: true,
     supportsTraceUpdates: true,

packages/react-devtools-shared/src/backend/fiber/renderer.js

@@ -4701,7 +4701,7 @@ export function attach(
       return;
     }
     pushOperation(SUSPENSE_TREE_OPERATION_REORDER_CHILDREN);
-    // $FlowFixMe[incompatible-call] TODO: Allow filtering SuspenseNode
+    // $FlowFixMe[incompatible-type] TODO: Allow filtering SuspenseNode
     pushOperation(parentInstance.instance.id);
     pushOperation(numChildren);
     for (let i = 0; i < nextChildren.length; i++) {