diff --git a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java index aee7ae6ff196..a8bc5b18a261 100644 --- a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java +++ b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java @@ -18,6 +18,7 @@ package org.eclipse.e4.ui.workbench.renderers.swt; import java.lang.reflect.Field; +import java.util.Arrays; import java.util.Objects; import org.eclipse.core.runtime.Platform; import org.eclipse.core.runtime.preferences.IEclipsePreferences; @@ -621,17 +622,42 @@ void drawSelectedTab(int itemIndex, GC gc, Rectangle bounds) { } if (selectedTabHighlightColor != null) { + gc.setForeground(selectedTabHighlightColor); gc.setBackground(selectedTabHighlightColor); + int originalLineWidth = gc.getLineWidth(); + int highlightHeight = 2; boolean highlightOnTop = drawTabHighlightOnTop; if (onBottom) { highlightOnTop = !highlightOnTop; } - int highlightHeight = 2; - int verticalOffset = highlightOnTop ? 0 : bounds.height - (highlightHeight - 1); - int horizontalOffset = itemIndex == 0 || cornerSize == SQUARE_CORNER ? 0 : 1; - int widthAdjustment = cornerSize == SQUARE_CORNER ? 0 : 1; - gc.fillRectangle(bounds.x + horizontalOffset, bounds.y + verticalOffset, bounds.width - widthAdjustment, - highlightHeight); + + if (highlightOnTop != onBottom && cornerSize != SQUARE_CORNER) { + // When using round tabs, extract the part of the outline that covers the + // highlight and draw it with adapted height + int[] highlightShape = Arrays.copyOfRange(tabOutlinePoints, 14, tabOutlinePoints.length - 14); + int yEnd = !highlightOnTop + ? outlineBoundsForOutline.y + outlineBoundsForOutline.height - highlightHeight + 1 + : highlightHeight; + highlightShape[1] = highlightShape[highlightShape.length - 1] = yEnd; + boolean gcAdvanced = gc.getAdvanced(); + gc.setAdvanced(false); + gc.fillPolygon(highlightShape); + gc.setAdvanced(gcAdvanced); + } else { + // When using square tab or drawing the highlight at the bottom, simply draw a + // line + int highlightY = highlightOnTop ? outlineBoundsForOutline.y + : bounds.y + bounds.height - highlightHeight + (!onBottom ? 1 : 0); + gc.fillRectangle(outlineBoundsForOutline.x, highlightY, outlineBoundsForOutline.width, highlightHeight); + if (highlightOnTop && !onBottom) { + // Compensate for the outline being draw on top of the filled region by + // extending the highlight with an equally wide line next to the filled region + gc.setLineWidth(1); + gc.drawLine(outlineBoundsForOutline.x, highlightY + highlightHeight, + outlineBoundsForOutline.x + outlineBoundsForOutline.width, highlightY + highlightHeight); + } + } + gc.setLineWidth(originalLineWidth); } if (backgroundPattern != null) {