[Apps] use source code path from bundle when deploying via asset bundle

[mniehoff]

Describe the issue

When deploying an app the source-code-path must be supplied with databricks apps deploy <app-name> instead of falling back to the source-code-path configured for resources.apps.<app-name>.source_code_path in a asset bundle

Configuration

resources:
  apps:
    some_app:
      name: "some_app"
      source_code_path: some_app

• root_path specified for the target/bundle.

Expected Behavior

databricks apps deploy runs without specifying source-code-path, but the source code path is taken form the bundle config + the root_path.

Also, I would be nice if the correct source code path (configured in the bundles) is also shown in the databricks UI when opening the app configuration.

Actual Behavior

source-code-path needs to be specified

OS and CLI version

cli v0.280.0

[andrewnester]

In the context of DABs, to deploy the app, you should use databricks bundle deploy, which indeed takes the path from what is configured in the DABs config. If you need to parameterise it, you can use bundle variables and then pass them to databricks bundle deploy.

databricks apps deploy is a separate CLI command to be used for apps which are not part of bundle

[mniehoff]

You are right, the bundle deploy creates the app resource and also deploys the App (when starting the app with bundle run <app-name>)

The app resource page in the control plane suggests that an additional apps deploy --source-code-path is necessary to have the app code deployment done. Maybe it's worth hinting to the bundle on the overview page of the app or not even showing the "Edit in your IDE" section, when the app was deployed using a bundle.

Thanks anyway, i will close the issue 🙂

[mniehoff]

I have to reopen the issue:

when i deploy an new app using asset bundles

variables:
  sql_warehouse_id:
    lookup:
      warehouse: 'App Warehouse'

resources:
  apps:
    test_app:
      name: "test"
      description: "Testing Deployment"
      compute_size: MEDIUM
      resources:
        - name: sql-warehouse
          sql_warehouse:
            id: ${var.sql_warehouse_id}
            permission: CAN_USE
      user_api_scopes:
        - sql
      source_code_path: metadata

(metadata is a folder in the same directory as the yaml file. yaml file is not the root yaml file databricks.yml)

it does not contain any source code in the deployed app compute resource. the source code can only be added by app deploy --source-code-path. I would have expected the source code already deployed, as configured in the bundle

I also tried source_code_path: ${workspace.file_path}/metadata and source_code_path: ${workspace.root_path}/files/apps/metadata, same effect

Also, when looking at the bare app, after deployment with asset bundles with databricks apps get metadata the default_source_code_path is empty. It will only be set by the apps deploy --source-code-path command.

I guess the correct request would be "set default_source_code_path to the path configured in bundle, when app is deployed via asset bundle"

[andrewnester]

@mniehoff

bundle deploy creates the app resource and also deploys the App (when starting the app with bundle run )

An important part is that bundle deploy does not actually deploy the app and the source code; it is only deployed when the app is started with the bundle run <app-name> command. I see why it can be confusing, though. The reason apps are not deployed and only created when "bundle deploy" is run is that deploying apps requires starting the underlying compute, which incurs inquiry costs for this app, which may not be necessary. Thus, starting and deploying the app is done via a separate "bundle run" call.

https://docs.databricks.com/aws/en/dev-tools/bundles/apps-tutorial#deploy-the-updated-bundle

[mniehoff]

ok, i see and makes absolute sense. also with bundle run its running fine for me.

But I would expect the same behavior when I start the App in the UI and not via bundle run. But in this case, the source code path needs to given by defining a deployment. Wouldn't here setting the default_source_code_path for app while deploying the bunlde make sense, so that also a start via the UI would work?

I know, its quite an edge case, because as soon as the first deployment has happened via bundle run, everything works as expected. But would be nice to have "ready-to-use-app" also for non techie users, right after a new bundle/app has been deployed.

[andrewnester]

@mniehoff it does make sense, but unfortunately Apps API itself does not allow setting default_source_code_path as part of app creation https://docs.databricks.com/api/workspace/apps/create

I'll relay this feedback to the Apps team, as it might be something that's useful from an API side perspective as well

[github-actions]

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[Azouu]

Hello ! Any update on this issue ?

[andrewnester]

@Azouu this will be addressed by the following change which will start the app automatically and therefore deploy it with a correct source_code_path from the start #4672