🤖 feat: backend-owned timing stats + stats tab experiment

Change-Id: I7d3f690636877046c1096c6003b9f2e58d2a9877
Signed-off-by: Thomas Kosiewski <[email protected]>

Author: ThomasK33

.storybook/mocks/orpc.ts

@@ -6,7 +6,11 @@
 import type { APIClient } from "@/browser/contexts/API";
 import type { FrontendWorkspaceMetadata } from "@/common/types/workspace";
 import type { ProjectConfig } from "@/node/config";
-import type { WorkspaceChatMessage, ProvidersConfigMap } from "@/common/orpc/types";
+import type {
+  WorkspaceChatMessage,
+  ProvidersConfigMap,
+  WorkspaceStatsSnapshot,
+} from "@/common/orpc/types";
 import type { ChatStats } from "@/common/types/chatStats";
 import { DEFAULT_RUNTIME_CONFIG } from "@/common/constants/workspace";
 import { createAsyncMessageQueue } from "@/common/utils/asyncMessageQueue";
@@ -69,6 +73,8 @@ export interface MockORPCClientOptions {
     }>
   >;
   /** Session usage data per workspace (for Costs tab) */
+  workspaceStatsSnapshots?: Map<string, WorkspaceStatsSnapshot>;
+  statsTabVariant?: "control" | "stats";
   sessionUsage?: Map<string, MockSessionUsage>;
   /** MCP server configuration per project */
   mcpServers?: Map<
@@ -112,11 +118,27 @@ export function createMockORPCClient(options: MockORPCClientOptions = {}): APICl
     onProjectRemove,
     backgroundProcesses = new Map(),
     sessionUsage = new Map(),
+    workspaceStatsSnapshots = new Map<string, WorkspaceStatsSnapshot>(),
+    statsTabVariant = "control",
     mcpServers = new Map(),
     mcpOverrides = new Map(),
     mcpTestResults = new Map(),
   } = options;
 
+  // Feature flags
+  let statsTabOverride: "default" | "on" | "off" = "default";
+
+  const getStatsTabState = () => {
+    const enabled =
+      statsTabOverride === "on"
+        ? true
+        : statsTabOverride === "off"
+          ? false
+          : statsTabVariant === "stats";
+
+    return { enabled, variant: statsTabVariant, override: statsTabOverride } as const;
+  };
+
   const workspaceMap = new Map(workspaces.map((w) => [w.id, w]));
 
   const mockStats: ChatStats = {
@@ -135,6 +157,16 @@ export function createMockORPCClient(options: MockORPCClientOptions = {}): APICl
         _input.texts.map(() => 0),
       calculateStats: async () => mockStats,
     },
+    features: {
+      getStatsTabState: async () => getStatsTabState(),
+      setStatsTabOverride: async (input: { override: "default" | "on" | "off" }) => {
+        statsTabOverride = input.override;
+        return getStatsTabState();
+      },
+    },
+    telemetry: {
+      track: async () => undefined,
+    },
     server: {
       getLaunchProject: async () => null,
       getSshHost: async () => null,
@@ -250,12 +282,12 @@ export function createMockORPCClient(options: MockORPCClientOptions = {}): APICl
       },
       onMetadata: async function* () {
         // Empty generator - no metadata updates in mock
-        await new Promise(() => {}); // Never resolves, keeps stream open
+        return;
       },
       activity: {
         list: async () => ({}),
         subscribe: async function* () {
-          await new Promise(() => {}); // Never resolves
+          return;
         },
       },
       backgroundBashes: {
@@ -271,6 +303,18 @@ export function createMockORPCClient(options: MockORPCClientOptions = {}): APICl
         terminate: async () => ({ success: true, data: undefined }),
         sendToBackground: async () => ({ success: true, data: undefined }),
       },
+      stats: {
+        subscribe: async function* (input: { workspaceId: string }) {
+          const snapshot = workspaceStatsSnapshots.get(input.workspaceId);
+          if (snapshot) {
+            yield snapshot;
+          }
+        },
+        clear: async (input: { workspaceId: string }) => {
+          workspaceStatsSnapshots.delete(input.workspaceId);
+          return { success: true, data: undefined };
+        },
+      },
       getSessionUsage: async (input: { workspaceId: string }) => sessionUsage.get(input.workspaceId),
       mcp: {
         get: async (input: { workspaceId: string }) => mcpOverrides.get(input.workspaceId) ?? {},

src/browser/App.tsx

@@ -55,6 +55,8 @@ import { SplashScreenProvider } from "./components/splashScreens/SplashScreenPro
 import { TutorialProvider } from "./contexts/TutorialContext";
 import { ConnectionStatusIndicator } from "./components/ConnectionStatusIndicator";
 import { TooltipProvider } from "./components/ui/tooltip";
+import { useFeatureFlags } from "./contexts/FeatureFlagsContext";
+import { FeatureFlagsProvider } from "./contexts/FeatureFlagsContext";
 import { ExperimentsProvider } from "./contexts/ExperimentsContext";
 import { getWorkspaceSidebarKey } from "./utils/workspace";
 
@@ -131,6 +133,11 @@ function AppInner() {
   // Get workspace store for command palette
   const workspaceStore = useWorkspaceStoreRaw();
 
+  const { statsTabState } = useFeatureFlags();
+  useEffect(() => {
+    workspaceStore.setStatsEnabled(Boolean(statsTabState?.enabled));
+  }, [workspaceStore, statsTabState?.enabled]);
+
   // Track telemetry when workspace selection changes
   const prevWorkspaceRef = useRef<WorkspaceSelection | null>(null);
   useEffect(() => {
@@ -449,6 +456,7 @@ function AppInner() {
     onToggleTheme: toggleTheme,
     onSetTheme: setThemePreference,
     onOpenSettings: openSettings,
+    onClearTimingStats: (workspaceId: string) => workspaceStore.clearTimingStats(workspaceId),
     api,
   };
 
@@ -761,17 +769,19 @@ function App() {
   return (
     <ThemeProvider>
       <ExperimentsProvider>
-        <TooltipProvider delayDuration={200}>
-          <SettingsProvider>
-            <SplashScreenProvider>
-              <TutorialProvider>
-                <CommandRegistryProvider>
-                  <AppInner />
-                </CommandRegistryProvider>
-              </TutorialProvider>
-            </SplashScreenProvider>
-          </SettingsProvider>
-        </TooltipProvider>
+        <FeatureFlagsProvider>
+          <TooltipProvider delayDuration={200}>
+            <SettingsProvider>
+              <SplashScreenProvider>
+                <TutorialProvider>
+                  <CommandRegistryProvider>
+                    <AppInner />
+                  </CommandRegistryProvider>
+                </TutorialProvider>
+              </SplashScreenProvider>
+            </SettingsProvider>
+          </TooltipProvider>
+        </FeatureFlagsProvider>
       </ExperimentsProvider>
     </ThemeProvider>
   );

src/browser/components/AIView.tsx

@@ -41,11 +41,13 @@ import { useAutoScroll } from "@/browser/hooks/useAutoScroll";
 import { useOpenTerminal } from "@/browser/hooks/useOpenTerminal";
 import { useOpenInEditor } from "@/browser/hooks/useOpenInEditor";
 import { usePersistedState } from "@/browser/hooks/usePersistedState";
+import { useFeatureFlags } from "@/browser/contexts/FeatureFlagsContext";
 import { useThinking } from "@/browser/contexts/ThinkingContext";
 import {
   useWorkspaceState,
   useWorkspaceAggregator,
   useWorkspaceUsage,
+  useWorkspaceStatsSnapshot,
 } from "@/browser/stores/WorkspaceStore";
 import { WorkspaceHeader } from "./WorkspaceHeader";
 import { getModelName } from "@/common/utils/ai/models";
@@ -106,7 +108,8 @@ const AIViewInner: React.FC<AIViewProps> = ({
 
   // Resizable RightSidebar width - separate hooks per tab for independent persistence
   const costsSidebar = useResizableSidebar({
-    enabled: selectedRightTab === "costs",
+    // Costs + Stats share the same resizable width persistence
+    enabled: selectedRightTab === "costs" || selectedRightTab === "stats",
     defaultWidth: 300,
     minWidth: 300,
     maxWidth: 1200,
@@ -127,6 +130,9 @@ const AIViewInner: React.FC<AIViewProps> = ({
   const startResize =
     selectedRightTab === "review" ? reviewSidebar.startResize : costsSidebar.startResize;
 
+  const statsSnapshot = useWorkspaceStatsSnapshot(workspaceId);
+  const { statsTabState } = useFeatureFlags();
+  const statsEnabled = Boolean(statsTabState?.enabled);
   const workspaceState = useWorkspaceState(workspaceId);
   const aggregator = useWorkspaceAggregator(workspaceId);
   const workspaceUsage = useWorkspaceUsage(workspaceId);
@@ -705,14 +711,18 @@ const AIViewInner: React.FC<AIViewProps> = ({
                     awaitingUserQuestion
                       ? undefined
                       : activeStreamMessageId
-                        ? aggregator?.getStreamingTokenCount(activeStreamMessageId)
+                        ? statsEnabled && statsSnapshot?.active?.messageId === activeStreamMessageId
+                          ? statsSnapshot.active.liveTokenCount
+                          : aggregator?.getStreamingTokenCount(activeStreamMessageId)
                         : undefined
                   }
                   tps={
                     awaitingUserQuestion
                       ? undefined
                       : activeStreamMessageId
-                        ? aggregator?.getStreamingTPS(activeStreamMessageId)
+                        ? statsEnabled && statsSnapshot?.active?.messageId === activeStreamMessageId
+                          ? statsSnapshot.active.liveTPS
+                          : aggregator?.getStreamingTPS(activeStreamMessageId)
                         : undefined
                   }
                 />