Skip to content

Commit aed85d2

Browse files
Venefilynjelly
authored andcommitted
_scripts: revert arg for generate release notes
I had previously changed the `released` argument of generate release notes script to function in reverse by renaming it to `increment` instead. My assumption had been that `released` was used when we didn't want to update version for the blog post, and instead felt it would be easier to have an `increment` argument instead. This reverts it back to how it was before Related-to: 86c40fb Signed-off-by: Freya Gustavsson <[email protected]>
1 parent e200c6a commit aed85d2

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

_scripts/generate-release-notes

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ import json
1212
import os
1313
import re
1414
import sys
15-
import urllib
16-
import urllib.error
1715
from html.parser import HTMLParser
1816
from pathlib import Path
1917
from typing import Any
@@ -421,10 +419,10 @@ def main():
421419
help="Preview release notes with open PRs and more info",
422420
)
423421
parser.add_argument(
424-
"-i",
425-
"--increment",
422+
"-r",
423+
"--released",
426424
action="store_true",
427-
help="Increment Cockpit version",
425+
help="Cockpit has been released (do not increment version)",
428426
)
429427
# TODO: validate author
430428
parser.add_argument(
@@ -442,7 +440,7 @@ def main():
442440
args = parser.parse_args()
443441
user = args.user
444442

445-
increment = 1 if args.increment else 0
443+
increment = 0 if args.released else 1
446444
final_notes = construct_all_the_notes(user, args.preview, increment, args.verbose)
447445
output_filename = Path("_posts") / markdown_filename()
448446
with open(output_filename, "w", encoding="utf-8") as f:

0 commit comments

Comments
 (0)