From 83cc761e1f3c50a2ace33c8874e973277e97601e Mon Sep 17 00:00:00 2001 From: Philipp Thun Date: Fri, 20 Mar 2026 11:59:29 +0100 Subject: [PATCH] Remove unnecessary route.reload after updating destinations The reload and return value were unused by all callers. Removing them fixes a race condition where concurrent route deletion caused 500 errors. Observed error: Record not found (Sequel::NoExistingObject) at update_route_destinations.rb:97 in reload --- app/actions/update_route_destinations.rb | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/actions/update_route_destinations.rb b/app/actions/update_route_destinations.rb index c8a2c8a8ce5..66b0445e333 100644 --- a/app/actions/update_route_destinations.rb +++ b/app/actions/update_route_destinations.rb @@ -93,10 +93,6 @@ def update(route, to_add, to_delete, user_audit_info, manifest_triggered) update_processes(processes_to_ports_map) end - - route.reload - - route end def update_processes(processes_to_ports_map)