ARTEMIS-5863 use empty string for null values to match properties fil…#6201
ARTEMIS-5863 use empty string for null values to match properties fil…#6201clebertsuconic merged 1 commit intoapache:mainfrom
Conversation
| } | ||
| assertFalse(properties.isEmpty()); | ||
| assertTrue(properties.containsKey("acceptorConfigurations.test.params.useKQueue")); | ||
| assertEquals("", properties.get("acceptorConfigurations.test.params.useKQueue")); |
There was a problem hiding this comment.
I think you should also parse the output, and make sure the value will be null on the TransportConnections.
There was a problem hiding this comment.
it won't be null, it will be an empty string!
There was a problem hiding this comment.
we don't currently have a way to set a null value, it looks like we may need that to keep this consistent, and export null values as the null string. and check for it when we set properties and replace it with the null object.
There was a problem hiding this comment.
just thinking now... I guess we should settle with empty strings... otherwise things can get messy
what if you make it null on an existing configuration.
It's kind of difficult to mess with setting as it could mess with existing configurations. Hard to predict
…es conventions and retain keys that have null values
2 participants
…es conventions and retain keys that have null values