PUT/:id run forever

[barata0]

Item	Version
generator-angular-fullstack	3.10.8
Node	4.4.7
npm	3.10.8
Operating System	Fedora 22

Item	Answer
Transpiler	Babel
Markup	HTML
CSS	LESS
Router	ui-router
Client Tests	Mocha
DB	MongoDB
Auth	Y

After initializing the app with yo angular-fullstack

Find any inexisting id for a thing. e.g: 57f016222b63c46b76bf9980

So

GET localhost:3000/api/things/57f016222b63c46b76bf9980

returns 404 not found!

When trying to put an thing with this ID:

e.g:

PUT localhost:3000/api/things/57f016222b63c46b76bf9980

body: {"name": "hello"}

The item is created on the database but HTML get no response at all (browser waiting forever...)

To fix I added a handleEntityNotFound on the file:server/api/thing/thing.controller.js (line 100) on the upsert method

export function upsert(req, res) {
  if(req.body._id) {
    delete req.body._id;
  }
  return VizField.findOneAndUpdate({_id: req.params.id}, req.body, {upsert: false, setDefaultsOnInsert: true, runValidators: true}).exec()
    .then(handleEntityNotFound(res))    // <-- NEW CODE HERE
    .then(respondWithResult(res))
    .catch(handleError(res));
}

But as the PUT method returns the old instance, I get a 404 response with this approach which is ugly and may let the client confused.

To get the newly created instance you must pass the option {new: true} as param on the findByIdAndUpdate method.

But this way the integration spec is broken because it expects the OLD instance after PUT and not the newly UPDATED instance

[barata0]

Another points to consider are:

1. When creating a new instance on PUT http status must return 201.
2. The socket does not notify clients through the findByIdAndUpdate method.

[Awk34]

We don't have a 1.8.5 version, so please check that.

[Awk34]

According to the RFC, you're correct about the response codes.

[barata0]

The version was wrong (thanks).

I'm not sure but PUT shouldn't also replace the entire entity and not only the fields present on the request body.

And is there a thread or discussion explainig why does PUT returns the old instance instead the new one?

Ps. I don't know if here is the most appropriate place to discuss this. Please let me know if there is another place.

Thanks for this great job.

[barata0]

Sorry. I didnt want to close the request. just the window....

[Awk34]

A PUT should fully replace the stored entity. That's how the RFC defines it.

As for what is returned by a PUT, I don't believe there's any spec on that. There could probably be a case for either, or maybe even sending both old and new.

[tommybananas]

I think returning the new object by default would be the best choice.

[barata0]

Closing due inactivity