-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Open
Labels
B-buildIncludes scripting, bazel and CI integrationsIncludes scripting, bazel and CI integrationsB-managerSelenium ManagerSelenium ManagerC-dotnet.NET Bindings.NET BindingsC-javaJava BindingsJava BindingsC-nodejsJavaScript BindingsJavaScript BindingsC-pyPython BindingsPython BindingsC-rbRuby BindingsRuby BindingsI-enhancementSomething could be betterSomething could be better
Description
Description
We made a change here to always use pin_browsers in CI: #15987
This removed all testing of Selenium Manager. This removed testing our suites with Selenium Manager.
Ideally each binding has Service class tests that exercise Selenium Manager (some of them seem to do this already), and these tests will only work on GitHub Actions and not on RBE.
Have you considered any alternatives or workarounds?
I think we may want to make pin_browsers the default for Bazel, and explicitly set it to false for Selenium Manager tests:
implemented the first part here: #16743
Metadata
Metadata
Assignees
Labels
B-buildIncludes scripting, bazel and CI integrationsIncludes scripting, bazel and CI integrationsB-managerSelenium ManagerSelenium ManagerC-dotnet.NET Bindings.NET BindingsC-javaJava BindingsJava BindingsC-nodejsJavaScript BindingsJavaScript BindingsC-pyPython BindingsPython BindingsC-rbRuby BindingsRuby BindingsI-enhancementSomething could be betterSomething could be better