Skip to content

Commit 3630164

Browse files
authored
Merge pull request #2 from OctopusDeploy/michrich/contenthash-serialization-bug
Resolve serialization error during check for changes
2 parents 98c0924 + 8a7a3b0 commit 3630164

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public class Main {
8181

8282
public static void main(String[] args) {
8383
var openFeature = OpenFeatureAPI.getInstance();
84-
openFeature.setProvider(new OctopusProvider(new OctopusConfiguration("Your Octopus client identifier")));
84+
openFeature.setProviderAndWait(new OctopusProvider(new OctopusConfiguration("Your Octopus client identifier")));
8585
var openFeatureClient = openFeature.getClient();
8686

8787
var darkModeIsEnabled = openFeatureClient.getBooleanValue("dark-mode", false);

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>com.octopus.openfeature</groupId>
88
<artifactId>octopus-openfeature-provider</artifactId>
9-
<version>0.1.0</version>
9+
<version>0.2.0</version>
1010
<packaging>jar</packaging>
1111

1212
<name>Octopus Deploy OpenFeature Provider</name>

src/main/java/com/octopus/openfeature/provider/OctopusClient.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ Boolean haveFeatureTogglesChanged(byte[] contentHash)
2929
if (contentHash.length == 0) { return true; }
3030
URI checkURI = getCheckURI();
3131
HttpClient client = HttpClient.newHttpClient();
32-
// TODO: check client is v3
33-
HttpRequest request = HttpRequest.newBuilder()
32+
HttpRequest request = HttpRequest.newBuilder()
3433
.GET()
3534
.uri(checkURI)
3635
.header("Authorization", String.format("Bearer %s", config.getClientIdentifier()))
@@ -50,7 +49,6 @@ FeatureToggles getFeatureToggleEvaluationManifest()
5049
{
5150
URI manifestURI = getManifestURI();
5251
HttpClient client = HttpClient.newHttpClient();
53-
// TODO: check client is v3
5452
HttpRequest request = HttpRequest.newBuilder()
5553
.GET()
5654
.uri(manifestURI)
@@ -97,6 +95,6 @@ private Boolean isSuccessStatusCode(int statusCode) {
9795

9896
// This class needs to be static to allow deserialization
9997
private static class FeatureToggleCheckResponse {
100-
byte[] contentHash;
98+
public byte[] contentHash;
10199
}
102100
}

0 commit comments

Comments
 (0)