feat: wip vite setup

Author: NathanWalker

lib/constants.ts

@@ -224,7 +224,6 @@ export const CACACHE_DIRECTORY_NAME = "_cacache";
 export const FILES_CHANGE_EVENT_NAME = "filesChangeEvent";
 export const INITIAL_SYNC_EVENT_NAME = "initialSyncEvent";
 export const PREPARE_READY_EVENT_NAME = "prepareReadyEvent";
-export const WEBPACK_COMPILATION_COMPLETE = "webpackCompilationComplete";
 export const BUNDLER_COMPILATION_COMPLETE = "bundlerCompilationComplete";
 
 export class DebugCommandErrors {

lib/controllers/prepare-controller.ts

@@ -13,14 +13,14 @@ import { hook } from "../common/helpers";
 import { injector } from "../common/yok";
 import {
 	AnalyticsEventLabelDelimiter,
+	BUNDLER_COMPILATION_COMPLETE,
 	CONFIG_FILE_NAME_JS,
 	CONFIG_FILE_NAME_TS,
 	PACKAGE_JSON_FILE_NAME,
 	PLATFORMS_DIR_NAME,
 	PREPARE_READY_EVENT_NAME,
 	SupportedPlatform,
 	TrackActionNames,
-	WEBPACK_COMPILATION_COMPLETE,
 } from "../constants";
 import { IOptions, IWatchIgnoreListService } from "../declarations";
 import {
@@ -119,7 +119,7 @@ export class PrepareController extends EventEmitter {
 		) {
 			await this.$bundlerCompilerService.stopBundlerCompiler(platformLowerCase);
 			this.$bundlerCompilerService.removeListener(
-				WEBPACK_COMPILATION_COMPLETE,
+				BUNDLER_COMPILATION_COMPLETE,
 				this.webpackCompilerHandler,
 			);
 			this.watchersData[projectDir][
@@ -297,7 +297,7 @@ export class PrepareController extends EventEmitter {
 
 			this.webpackCompilerHandler = handler.bind(this);
 			this.$bundlerCompilerService.on(
-				WEBPACK_COMPILATION_COMPLETE,
+				BUNDLER_COMPILATION_COMPLETE,
 				this.webpackCompilerHandler,
 			);
 

lib/services/bundler/bundler-compiler-service.ts

@@ -224,14 +224,31 @@ export class BundlerCompilerService
 				});
 
 				childProcess.on("close", async (arg: any) => {
-					await this.$cleanupService.removeKillProcess(
-						childProcess.pid.toString(),
-					);
-
 					const exitCode = typeof arg === "number" ? arg : arg && arg.code;
 					this.$logger.trace(
 						`${capitalizeFirstLetter(projectData.bundler)} process exited with code ${exitCode} when we expected it to be long living with watch.`,
 					);
+					if (this.getBundler() === "vite" && exitCode === 0) {
+						// note experimental: investigate watch mode
+						const bundlePath = path.join(
+							projectData.projectDir,
+							"dist/bundle.js",
+						);
+						console.log("bundlePath:", bundlePath);
+						const data = {
+							files: [bundlePath],
+							hasOnlyHotUpdateFiles: false,
+							hmrData: {},
+							platform: platformData.platformNameLowerCase,
+						};
+						this.emit(BUNDLER_COMPILATION_COMPLETE, data);
+						resolve(1);
+						return;
+					}
+
+					await this.$cleanupService.removeKillProcess(
+						childProcess.pid.toString(),
+					);
 					const error: any = new Error(
 						`Executing ${projectData.bundler} failed with exit code ${exitCode}.`,
 					);
@@ -341,12 +358,15 @@ export class BundlerCompilerService
 			projectData,
 			prepareData,
 		);
-		const envParams = await this.buildEnvCommandLineParams(
-			envData,
-			platformData,
-			projectData,
-			prepareData,
-		);
+		const isVite = this.getBundler() === "vite";
+		const envParams = isVite
+			? [`--mode=${platformData.platformNameLowerCase}`]
+			: await this.buildEnvCommandLineParams(
+					envData,
+					platformData,
+					projectData,
+					prepareData,
+				);
 		const additionalNodeArgs =
 			semver.major(process.version) <= 8 ? ["--harmony"] : [];
 
@@ -366,8 +386,10 @@ export class BundlerCompilerService
 			...envParams,
 		].filter(Boolean);
 
-		if (prepareData.watch) {
-			args.push("--watch");
+		if (!isVite) {
+			if (prepareData.watch) {
+				args.push("--watch");
+			}
 		}
 
 		const stdio = prepareData.watch ? ["ipc"] : "inherit";
@@ -391,6 +413,8 @@ export class BundlerCompilerService
 			});
 		}
 
+		console.log("args:", args);
+
 		const childProcess = this.$childProcess.spawn(
 			process.execPath,
 			args,
@@ -670,7 +694,15 @@ export class BundlerCompilerService
 	private getBundlerExecutablePath(projectData: IProjectData): string {
 		const bundler = this.getBundler();
 
-		if (this.isModernBundler(projectData)) {
+		if (bundler === "vite") {
+			const packagePath = resolvePackagePath(`vite`, {
+				paths: [projectData.projectDir],
+			});
+
+			if (packagePath) {
+				return path.resolve(packagePath, "bin", "vite.js");
+			}
+		} else if (this.isModernBundler(projectData)) {
 			const packagePath = resolvePackagePath(`@nativescript/${bundler}`, {
 				paths: [projectData.projectDir],
 			});