diff --git a/azure/azure-release-pipeline.yml b/azure/azure-release-pipeline.yml index 0381209..946b141 100644 --- a/azure/azure-release-pipeline.yml +++ b/azure/azure-release-pipeline.yml @@ -66,6 +66,7 @@ extends: post_deploy: - template: templates/e2e.yml parameters: + app_id: "84aa2219-7170-4279-93fb-3d37b89bbc01" test_type: smoketest depends_on: - internal_qa @@ -73,6 +74,7 @@ extends: post_deploy: - template: templates/e2e.yml parameters: + app_id: "a50e2f01-ea28-41c9-8666-850c034ddd82" test_type: smoketest depends_on: - internal_qa @@ -80,6 +82,7 @@ extends: post_deploy: - template: templates/e2e.yml parameters: + app_id: "72ada63b-9d70-4ca2-b9f2-cd1ce74c2dde" test_type: smoketest depends_on: - int diff --git a/azure/templates/e2e.yml b/azure/templates/e2e.yml index dc1d6f3..5fb7052 100644 --- a/azure/templates/e2e.yml +++ b/azure/templates/e2e.yml @@ -1,5 +1,8 @@ parameters: - name: test_type + - name: app_id + type: string + default: "" steps: @@ -19,12 +22,12 @@ steps: displayName: poetry install - bash: | - export RELEASE_RELEASEID=$(Build.BuildId) export SOURCE_COMMIT_ID=$(Build.SourceVersion) export PROXY_NAME="$(FULLY_QUALIFIED_SERVICE_NAME)" export APIGEE_ACCESS_TOKEN="$(secret.AccessToken)" - export APIGEE_ENVIRONMENT="$(APIGEE_ENVIRONMENT)" export APIGEE_ORGANIZATION="nhsd-$(APIGEE_ORGANIZATION)" + export APIGEE_APP_ID=${{ parameters.app_id }} + export STATUS_ENDPOINT_API_KEY="$(STATUS_ENDPOINT_API_KEY)" make -C e2e ${{ parameters.test_type }} workingDirectory: $(SERVICE_DIR) diff --git a/e2e/Makefile b/e2e/Makefile index 88f7b91..bda8ea0 100644 --- a/e2e/Makefile +++ b/e2e/Makefile @@ -22,8 +22,10 @@ TEST_CMD := pytest \ --api-name=sync-wrap \ --proxy-name=$(PROXY_NAME) \ -ifdef APIGEE_ORGANIZATION - TEST_CMD += --apigee-organization=$(APIGEE_ORGANIZATION) +ifeq ($(APIGEE_ORGANIZATION), nhsd-prod) + TEST_CMD += --apigee-organization=$(APIGEE_ORGANIZATION) \ + --apigee-app-id=$(APIGEE_APP_ID) \ + --status-endpoint-api-key=$(STATUS_ENDPOINT_API_KEY) endif test: diff --git a/e2e/tests/api_tests.py b/e2e/tests/api_tests.py index 2b605a2..3c322c6 100644 --- a/e2e/tests/api_tests.py +++ b/e2e/tests/api_tests.py @@ -79,7 +79,7 @@ def _container_not_ready(resp: requests.Response): deployed_commit_id = resp.json().get("commitId") - while deployed_commit_id != getenv("SOURCE_COMMIT_ID") or _container_not_ready(resp) and retries <= 45: + while deployed_commit_id != getenv("SOURCE_COMMIT_ID") or _container_not_ready(resp) and retries <= 50: resp = requests.get( f"{nhsd_apim_proxy_url}/_status", headers=status_endpoint_auth_headers, timeout=30 )