Prevent instrumenting debugger agent classes#10803
Prevent instrumenting debugger agent classes#10803gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
Conversation
Skip all classes from debugger agent to avoid LinkageError attempted duplicate class definition error
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (319.386 µs) : 281, 358
. : milestone, 319,
basic (276.691 µs) : 271, 283
. : milestone, 277,
loop (8.946 ms) : 8940, 8952
. : milestone, 8946,
section candidate
noprobe (310.466 µs) : 288, 333
. : milestone, 310,
basic (279.898 µs) : 270, 290
. : milestone, 280,
loop (8.951 ms) : 8914, 8988
. : milestone, 8951,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 7 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~dd912e0d3a, baseline=1.61.0-SNAPSHOT~5a62cccf85
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059590
Total [baseline] (11.06 s) : 0, 11060415
Agent [candidate] (1.061 s) : 0, 1060909
Total [candidate] (11.052 s) : 0, 11051545
section appsec
Agent [baseline] (1.245 s) : 0, 1245114
Total [baseline] (11.117 s) : 0, 11116959
Agent [candidate] (1.262 s) : 0, 1262415
Total [candidate] (11.229 s) : 0, 11229361
section iast
Agent [baseline] (1.229 s) : 0, 1229260
Total [baseline] (11.335 s) : 0, 11335119
Agent [candidate] (1.226 s) : 0, 1225587
Total [candidate] (11.272 s) : 0, 11272051
section profiling
Agent [baseline] (1.182 s) : 0, 1181925
Total [baseline] (11.118 s) : 0, 11117916
Agent [candidate] (1.188 s) : 0, 1188476
Total [candidate] (11.118 s) : 0, 11117730
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~dd912e0d3a, baseline=1.61.0-SNAPSHOT~5a62cccf85
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (628.344 ms) : 0, 628344
BytebuddyAgent [candidate] (627.391 ms) : 0, 627391
AgentMeter [baseline] (29.096 ms) : 0, 29096
AgentMeter [candidate] (29.11 ms) : 0, 29110
GlobalTracer [baseline] (257.492 ms) : 0, 257492
GlobalTracer [candidate] (256.949 ms) : 0, 256949
AppSec [baseline] (31.516 ms) : 0, 31516
AppSec [candidate] (31.513 ms) : 0, 31513
Debugger [baseline] (59.404 ms) : 0, 59404
Debugger [candidate] (59.319 ms) : 0, 59319
Remote Config [baseline] (590.376 µs) : 0, 590
Remote Config [candidate] (579.332 µs) : 0, 579
Telemetry [baseline] (8.673 ms) : 0, 8673
Telemetry [candidate] (8.622 ms) : 0, 8622
Flare Poller [baseline] (7.096 ms) : 0, 7096
Flare Poller [candidate] (10.203 ms) : 0, 10203
section appsec
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (657.112 ms) : 0, 657112
BytebuddyAgent [candidate] (667.989 ms) : 0, 667989
AgentMeter [baseline] (12.03 ms) : 0, 12030
AgentMeter [candidate] (12.155 ms) : 0, 12155
GlobalTracer [baseline] (258.049 ms) : 0, 258049
GlobalTracer [candidate] (261.604 ms) : 0, 261604
IAST [baseline] (23.921 ms) : 0, 23921
IAST [candidate] (24.279 ms) : 0, 24279
AppSec [baseline] (177.678 ms) : 0, 177678
AppSec [candidate] (178.896 ms) : 0, 178896
Debugger [baseline] (65.708 ms) : 0, 65708
Debugger [candidate] (66.29 ms) : 0, 66290
Remote Config [baseline] (574.39 µs) : 0, 574
Remote Config [candidate] (592.771 µs) : 0, 593
Telemetry [baseline] (8.953 ms) : 0, 8953
Telemetry [candidate] (9.2 ms) : 0, 9200
Flare Poller [baseline] (3.624 ms) : 0, 3624
Flare Poller [candidate] (3.612 ms) : 0, 3612
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (797.72 ms) : 0, 797720
BytebuddyAgent [candidate] (794.453 ms) : 0, 794453
AgentMeter [baseline] (11.352 ms) : 0, 11352
AgentMeter [candidate] (11.329 ms) : 0, 11329
GlobalTracer [baseline] (247.684 ms) : 0, 247684
GlobalTracer [candidate] (247.314 ms) : 0, 247314
IAST [baseline] (25.179 ms) : 0, 25179
IAST [candidate] (25.11 ms) : 0, 25110
AppSec [baseline] (26.472 ms) : 0, 26472
AppSec [candidate] (26.445 ms) : 0, 26445
Debugger [baseline] (64.534 ms) : 0, 64534
Debugger [candidate] (63.42 ms) : 0, 63420
Remote Config [baseline] (551.615 µs) : 0, 552
Remote Config [candidate] (520.596 µs) : 0, 521
Telemetry [baseline] (14.083 ms) : 0, 14083
Telemetry [candidate] (15.206 ms) : 0, 15206
Flare Poller [baseline] (4.439 ms) : 0, 4439
Flare Poller [candidate] (4.559 ms) : 0, 4559
section profiling
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (682.466 ms) : 0, 682466
BytebuddyAgent [candidate] (687.288 ms) : 0, 687288
AgentMeter [baseline] (8.595 ms) : 0, 8595
AgentMeter [candidate] (8.635 ms) : 0, 8635
GlobalTracer [baseline] (215.634 ms) : 0, 215634
GlobalTracer [candidate] (216.479 ms) : 0, 216479
AppSec [baseline] (31.945 ms) : 0, 31945
AppSec [candidate] (32.23 ms) : 0, 32230
Debugger [baseline] (64.565 ms) : 0, 64565
Debugger [candidate] (64.813 ms) : 0, 64813
Remote Config [baseline] (589.932 µs) : 0, 590
Remote Config [candidate] (589.991 µs) : 0, 590
Telemetry [baseline] (8.959 ms) : 0, 8959
Telemetry [candidate] (8.177 ms) : 0, 8177
Flare Poller [baseline] (3.419 ms) : 0, 3419
Flare Poller [candidate] (4.244 ms) : 0, 4244
ProfilingAgent [baseline] (93.619 ms) : 0, 93619
ProfilingAgent [candidate] (93.558 ms) : 0, 93558
Profiling [baseline] (94.198 ms) : 0, 94198
Profiling [candidate] (94.126 ms) : 0, 94126
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~dd912e0d3a, baseline=1.61.0-SNAPSHOT~5a62cccf85
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059456
Total [baseline] (8.854 s) : 0, 8854341
Agent [candidate] (1.057 s) : 0, 1057427
Total [candidate] (8.827 s) : 0, 8827375
section iast
Agent [baseline] (1.227 s) : 0, 1226832
Total [baseline] (9.603 s) : 0, 9602576
Agent [candidate] (1.229 s) : 0, 1228610
Total [candidate] (9.577 s) : 0, 9577294
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~dd912e0d3a, baseline=1.61.0-SNAPSHOT~5a62cccf85
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (626.754 ms) : 0, 626754
BytebuddyAgent [candidate] (627.932 ms) : 0, 627932
AgentMeter [baseline] (29.116 ms) : 0, 29116
AgentMeter [candidate] (29.041 ms) : 0, 29041
GlobalTracer [baseline] (256.7 ms) : 0, 256700
GlobalTracer [candidate] (256.604 ms) : 0, 256604
AppSec [baseline] (31.516 ms) : 0, 31516
AppSec [candidate] (31.507 ms) : 0, 31507
Debugger [baseline] (58.622 ms) : 0, 58622
Debugger [candidate] (58.629 ms) : 0, 58629
Remote Config [baseline] (585.723 µs) : 0, 586
Remote Config [candidate] (595.54 µs) : 0, 596
Telemetry [baseline] (8.6 ms) : 0, 8600
Telemetry [candidate] (8.689 ms) : 0, 8689
Flare Poller [baseline] (10.316 ms) : 0, 10316
Flare Poller [candidate] (7.166 ms) : 0, 7166
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (796.351 ms) : 0, 796351
BytebuddyAgent [candidate] (797.351 ms) : 0, 797351
AgentMeter [baseline] (11.306 ms) : 0, 11306
AgentMeter [candidate] (11.318 ms) : 0, 11318
GlobalTracer [baseline] (247.514 ms) : 0, 247514
GlobalTracer [candidate] (247.65 ms) : 0, 247650
IAST [baseline] (25.105 ms) : 0, 25105
IAST [candidate] (25.106 ms) : 0, 25106
AppSec [baseline] (26.334 ms) : 0, 26334
AppSec [candidate] (26.338 ms) : 0, 26338
Debugger [baseline] (62.669 ms) : 0, 62669
Debugger [candidate] (63.138 ms) : 0, 63138
Remote Config [baseline] (531.217 µs) : 0, 531
Remote Config [candidate] (526.196 µs) : 0, 526
Telemetry [baseline] (15.133 ms) : 0, 15133
Telemetry [candidate] (15.377 ms) : 0, 15377
Flare Poller [baseline] (4.682 ms) : 0, 4682
Flare Poller [candidate] (4.414 ms) : 0, 4414
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~dd912e0d3a, baseline=1.61.0-SNAPSHOT~5a62cccf85
dateFormat X
axisFormat %s
section baseline
no_agent (1.187 ms) : 1176, 1199
. : milestone, 1187,
iast (3.264 ms) : 3220, 3309
. : milestone, 3264,
iast_FULL (5.701 ms) : 5644, 5758
. : milestone, 5701,
iast_GLOBAL (3.536 ms) : 3476, 3595
. : milestone, 3536,
profiling (2.152 ms) : 2132, 2173
. : milestone, 2152,
tracing (1.788 ms) : 1772, 1803
. : milestone, 1788,
section candidate
no_agent (1.205 ms) : 1194, 1216
. : milestone, 1205,
iast (3.267 ms) : 3220, 3313
. : milestone, 3267,
iast_FULL (5.689 ms) : 5633, 5745
. : milestone, 5689,
iast_GLOBAL (3.55 ms) : 3485, 3616
. : milestone, 3550,
profiling (1.996 ms) : 1979, 2013
. : milestone, 1996,
tracing (1.883 ms) : 1865, 1901
. : milestone, 1883,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~dd912e0d3a, baseline=1.61.0-SNAPSHOT~5a62cccf85
dateFormat X
axisFormat %s
section baseline
no_agent (19.509 ms) : 19309, 19709
. : milestone, 19509,
appsec (19.002 ms) : 18810, 19194
. : milestone, 19002,
code_origins (17.671 ms) : 17498, 17845
. : milestone, 17671,
iast (17.653 ms) : 17481, 17825
. : milestone, 17653,
profiling (18.846 ms) : 18662, 19030
. : milestone, 18846,
tracing (17.576 ms) : 17402, 17749
. : milestone, 17576,
section candidate
no_agent (19.183 ms) : 18988, 19378
. : milestone, 19183,
appsec (18.553 ms) : 18366, 18741
. : milestone, 18553,
code_origins (17.583 ms) : 17410, 17756
. : milestone, 17583,
iast (18.14 ms) : 17957, 18323
. : milestone, 18140,
profiling (18.927 ms) : 18737, 19117
. : milestone, 18927,
tracing (18.542 ms) : 18357, 18728
. : milestone, 18542,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~dd912e0d3a, baseline=1.61.0-SNAPSHOT~5a62cccf85
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.519 ms) : 2464, 2574
. : milestone, 2519,
iast (2.245 ms) : 2176, 2314
. : milestone, 2245,
iast_GLOBAL (2.299 ms) : 2230, 2369
. : milestone, 2299,
profiling (2.071 ms) : 2017, 2126
. : milestone, 2071,
tracing (2.046 ms) : 1993, 2100
. : milestone, 2046,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.518 ms) : 2463, 2573
. : milestone, 2518,
iast (2.254 ms) : 2185, 2323
. : milestone, 2254,
iast_GLOBAL (2.285 ms) : 2216, 2355
. : milestone, 2285,
profiling (2.097 ms) : 2041, 2153
. : milestone, 2097,
tracing (2.056 ms) : 2002, 2110
. : milestone, 2056,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~dd912e0d3a, baseline=1.61.0-SNAPSHOT~5a62cccf85
dateFormat X
axisFormat %s
section baseline
no_agent (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
appsec (15.083 s) : 15083000, 15083000
. : milestone, 15083000,
iast (17.657 s) : 17657000, 17657000
. : milestone, 17657000,
iast_GLOBAL (17.791 s) : 17791000, 17791000
. : milestone, 17791000,
profiling (14.874 s) : 14874000, 14874000
. : milestone, 14874000,
tracing (15.255 s) : 15255000, 15255000
. : milestone, 15255000,
section candidate
no_agent (15.556 s) : 15556000, 15556000
. : milestone, 15556000,
appsec (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
iast (17.816 s) : 17816000, 17816000
. : milestone, 17816000,
iast_GLOBAL (17.687 s) : 17687000, 17687000
. : milestone, 17687000,
profiling (14.924 s) : 14924000, 14924000
. : milestone, 14924000,
tracing (14.88 s) : 14880000, 14880000
. : milestone, 14880000,
|
| private static final boolean JAVA_AT_LEAST_19 = JavaVirtualMachine.isJavaVersionAtLeast(19); | ||
|
|
||
| public static Path DUMP_PATH = Paths.get(SystemProperties.get(JAVA_IO_TMPDIR), "debugger"); | ||
| private static final List<String> SKIPPED_PACKAGES = |
There was a problem hiding this comment.
💭 thought: Is there a benefits of using an ArrayList<String> over the lighter constant String[]?
There was a problem hiding this comment.
right, we can make this optimization
PerfectSlayer
left a comment
There was a problem hiding this comment.
Looks good to me. I would let live debugger team have a second pair of eyes for the product side of the change
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 101939357 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
c1e9ac6
into
master
What Does This Do
Skip all classes from debugger agent to avoid LinkageError attempted duplicate class definition error
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-5266
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.