PHPStan lvl 6 (#54)

Author: b1rdex

phpstan-baseline.neon

@@ -1,27 +0,0 @@
-parameters:
-	ignoreErrors:
-		-
-			message: "#^Access to an undefined property Doctrine\\\\Persistence\\\\Mapping\\\\ClassMetadata\\:\\:\\$customRepositoryClassName\\.$#"
-			count: 1
-			path: src/Codeception/Module/Doctrine2.php
-
-		-
-			message: "#^Access to an undefined property Doctrine\\\\Persistence\\\\Mapping\\\\ClassMetadata\\:\\:\\$name\\.$#"
-			count: 1
-			path: src/Codeception/Module/Doctrine2.php
-
-		-
-			message: "#^Call to an undefined method Doctrine\\\\Persistence\\\\ObjectRepository\\:\\:createQueryBuilder\\(\\)\\.$#"
-			count: 4
-			path: src/Codeception/Module/Doctrine2.php
-
-		-
-			message: "#^Dead catch \\- Doctrine\\\\Persistence\\\\Mapping\\\\MappingException is already caught by Doctrine\\\\Persistence\\\\Mapping\\\\MappingException above\\.$#"
-			count: 1
-			path: src/Codeception/Module/Doctrine2.php
-
-		-
-			message: "#^Unable to resolve the template type T in call to method Codeception\\\\Module\\\\Doctrine2\\:\\:instantiateAndPopulateEntity\\(\\)$#"
-			count: 2
-			path: src/Codeception/Module/Doctrine2.php
-

phpstan.neon

@@ -2,7 +2,7 @@ includes:
     - phpstan-baseline.neon
 
 parameters:
-  level: 3
+  level: 6
   paths:
     - src
     - tests
@@ -15,8 +15,12 @@ parameters:
   reportUnmatchedIgnoredErrors: false
   ignoreErrors:
       - path: tests/
-        message: '#no typehint specified#'
+        message: '#Property \S+ is never read, only written#'
       - path: tests/
-        message: '#no return typehint specified#'
+        message: '#Property \S+ is unused#'
       - path: tests/
-        message: '#does not specify its types#'
+        message: '#Method \S+ has parameter \S+ with no type specified#'
+      - path: tests/
+        message: '#Method \S+ has no return type specified#'
+      - path: tests/
+        message: '#(?:Method|Property) .+ with generic (?:interface|class) \S+ does not specify its types#'

src/Codeception/Module/Doctrine2.php

@@ -182,6 +182,11 @@ public function _inject(DoctrineProvider $dependentModule = null): void
         $this->dependentModule = $dependentModule;
     }
 
+    /**
+     * @param array<mixed> $settings
+     *
+     * @throws ModuleConfigException
+     */
     public function _beforeSuite($settings = []): void
     {
         $this->retrieveEntityManager();
@@ -704,8 +709,8 @@ public function loadFixtures($fixtures, bool $append = true): void
                 }
 
                 try {
-                    $fixtureInstance = new $fixture;
-                } catch (Exception $exception) {
+                    $fixtureInstance = new $fixture();
+                } catch (Exception $exception) { // @phpstan-ignore-line https://github.com/phpstan/phpstan/issues/6574
                     throw new ModuleException(
                         __CLASS__,
                         sprintf(