Skip to content

Commit b0030b7

Browse files
committed
build
1 parent 1848a43 commit b0030b7

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
name: Build Skia Artifacts
22

3-
permissions:
4-
contents: read
5-
packages: read
6-
73
on:
84
push:
95
branches:
@@ -78,11 +74,6 @@ jobs:
7874
linux-all:
7975
name: Linux (all)
8076
runs-on: ubuntu-latest
81-
container:
82-
image: ghcr.io/avaloniaui/clang-cross-builder:latest
83-
credentials:
84-
username: ${{ github.actor }}
85-
password: ${{ secrets.GITHUB_TOKEN }}
8677
steps:
8778
- name: Log in to GitHub Container Registry
8879
uses: docker/login-action@v3

scripts/build.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,12 @@ def build_target(target_os, arch, self_contained, debug):
285285
write_file(os.path.join(gn_dir, "args.gn"), dict_to_gn(args))
286286

287287
if not has_env_flag("DEBUG_SKIP_BUILD"):
288-
subprocess.run(['gn', 'gen', gn_dir], check = True)
288+
# On Windows, prefer the gn.bat inside depot_tools to ensure batch wrapper is used.
289+
if os.name == "nt" or sys.platform.startswith("win"):
290+
gn_cmd = "../depot_tools/gn.bat"
291+
else:
292+
gn_cmd = "gn"
293+
subprocess.run([gn_cmd, 'gen', gn_dir], check = True)
289294
subprocess.run(['ninja', '-C', gn_dir], check = True)
290295

291296

@@ -327,8 +332,7 @@ def main():
327332
debug = "--debug" in args
328333

329334
# prepend ./depot_tools to PATH
330-
depot_tools_path = os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "depot_tools"))
331-
os.environ["PATH"] = depot_tools_path + os.pathsep + os.environ.get("PATH", "")
335+
os.environ["PATH"] = DEPOT_TOOLS_PATH + os.pathsep + os.environ.get("PATH", "")
332336

333337

334338

0 commit comments

Comments
 (0)